Track share funnel actions - #443
Open
shilman wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shilman/action-telemetry #443 +/- ##
===========================================================
Coverage ? 74.18%
===========================================================
Files ? 164
Lines ? 12923
Branches ? 1142
===========================================================
Hits ? 9587
Misses ? 3319
Partials ? 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Share popup telemetry to record funnel actions (open/publish/sign-in/subdomain/back) instead of emitting “screen viewed” impression events, aligning Share’s instrumentation with the action-based funnel approach introduced in #442.
Changes:
- Extends the global
TelemetryActionvocabulary withopenShareandpublish. - Emits action telemetry for Share popup open + key user interactions (publish, sign-in choices, subdomain submit, back).
- Replaces prior “view” telemetry tests with action-oriented assertions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/TelemetryContext.tsx | Adds openShare/publish to the typed action vocabulary. |
| src/screens/SharePopup/useShareExecution.ts | Emits an openShare action once per Share popup mount. |
| src/screens/SharePopup/SharePopup.tsx | Emits action telemetry from user interaction handlers across Share funnel screens. |
| src/screens/SharePopup/SharePopup.test.tsx | Updates tests to validate the new top-of-funnel action telemetry behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shilman
force-pushed
the
shilman/fix-share-actions
branch
from
July 28, 2026 16:30
2e83b21 to
8d6def4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ghengeveld I think this one is pretty uncontroversial.
Summary
Replaces the Share popup's screen-impression telemetry with action-style telemetry so the funnel records the user interactions that drive each transition.
This PR is stacked on #442.
openShareToolbarpublishShareWelcomesignInShareSignInsignInWithSSOShareSignInsubmitSubdomainShareSubdomaingoBackShareSubdomainAll events include
entryPoint: toolbarandlocation: SharePopup. The previousshare-welcome-viewed,share-signin-viewed, andshare-sso-viewedscreen events are removed.Test plan
yarn gate