docs(core-consensus): fix stale comment on round certificate validation#1570
Open
lau90eth wants to merge 1 commit into
Open
docs(core-consensus): fix stale comment on round certificate validation#1570lau90eth wants to merge 1 commit into
lau90eth wants to merge 1 commit into
Conversation
The comment claimed round certificates were not validated for sufficient voting power. This was true prior to commit 961fa4e (fix: Reject certificates with any invalid signature), which added full validation via verify_round_certificate: per-signature checks, duplicate-vote detection, and the 2f+1/f+1 threshold check. The comment was never updated to reflect this.
Contributor
|
Hi @lau90eth, Thank you for your interest in contributing to Malachite. This PR has been automatically closed because you are not assigned to issue #1569. We require contributors to be explicitly assigned to an issue before submitting a PR. To contribute properly:
Please see our CONTRIBUTING.md for more details. |
romac
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1569
Summary
The comment above
on_round_certificateinhandle/liveness.rsstates:This is no longer accurate. Commit 961fa4e ("fix: Reject certificates with any invalid signature") added full validation via
verify_round_certificateinsigning/src/ext.rs:The comment was never updated after that fix landed, which could mislead future contributors into thinking this validation gap still exists.
Change
Updated the doc comment to accurately describe the current validation behavior.
No functional changes.