Skip to content

docs(core-consensus): fix stale comment on round certificate validation #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lau90eth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(core-consensus): fix stale comment on round certificate validation #1570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions code/crates/core-consensus/src/handle/liveness.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,10 @@ where
/// the vote keeper will still be able to generate the threshold output using the existing
/// stored and incoming votes from the certificate.
///
/// (*) There is currently no validation of the correctness of the certificate in this function.
/// A byzantine validator may send a certificate that does not have enough votes to reach the
/// thresholds for `PrecommitAny` or `SkipRound`.
/// The round certificate is fully validated by `verify_round_certificate`,
/// which checks each vote signature and enforces the required voting-power
/// threshold for `PrecommitAny` (2f+1) or `SkipRound` (f+1) before this
/// function applies the certificate to the driver.
///
/// # Returns
/// * `Result<(), Error<Ctx>>` - Ok(()) if processing completed successfully,
Expand Down
Loading