feat(extra-natives/five): GET_WEAPON_ACCURACY_SPREAD & SET_WEAPON_ACC… #3356
+61
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
triage
|
Looks good. |
| accuracy_spread = *(int*)(weapon + weapon_spread_offset); | ||
| } | ||
|
|
||
| context.SetResult<int>(accuracy_spread); |
There was a problem hiding this comment.
Why in GET we return it as int and in SET we set float?
|
|
||
| if (auto weapon = getWeaponFromHash(context)) | ||
| { | ||
| accuracy_spread = *(int*)(weapon + weapon_spread_offset); |
There was a problem hiding this comment.
Could you use hook::FlexStruct to make this code easier to read please?
There was a problem hiding this comment.
And same notice about variable name styling
| @@ -354,6 +355,7 @@ static HookFunction hookFunction([]() | |||
| WeaponDamageModifierOffset = *hook::get_pattern<int>("48 8B 0C F8 89 B1", 6); | |||
| WeaponAnimationOverrideOffset = *hook::get_pattern<int>("8B 9F ? ? ? ? 85 DB 75 3E", 2); | |||
| WeaponRecoilShakeAmplitudeOffset = *hook::get_pattern<int>("48 8B 47 40 F3 0F 10 B0 ? ? ? ?", 8); | |||
| weapon_spread_offset = *hook::get_pattern<uint8_t>("F3 0F 59 59 ? F3 0F 59 D8", 4); | |||
There was a problem hiding this comment.
Use same name styling as above please
prikolium-cfx
requested changes
Apr 24, 2025
…struct and getter now uses a float
|
@bleenobtw can you squash the commits? and they're most likely going to merge this pull request. 😁 |
They get squashed when merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Introduces a way for client scripts to get & set the accuracy spread value of a weapon via it's hash.
How is this PR achieving the goal
By introducing
GET_WEAPON_ACCURACY_SPREAD&GET_WEAPON_ACCURACY_SPREADto allow client scripts to retrieve and set the spread of a weapon.This PR applies to the following area(s)
FiveM, Natives
Successfully tested on
Game builds: 2062, 3095, 3258
Platforms: Windows
Checklist
Fixes issues