Alternative lib directory for tests #8390
Open
+72
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8390 +/- ##
==========================================
- Coverage 88.80% 88.78% -0.03%
==========================================
Files 287 287
Lines 63236 63237 +1
Branches 7927 7927
==========================================
- Hits 56155 56143 -12
- Misses 4750 4764 +14
+ Partials 2331 2330 -1 🚀 New features to boost your workflow:
|
eaydingol
force-pushed
the
eag/mvtests-preso-workflow
branch
from
16b7478 to
b4269b6
Compare
eaydingol
changed the title
eaydingol
added a commit
to citusdata/the-process
that referenced
this pull request
Dec 25, 2025
Add the library files from the latest minor release to exttester image. These files will be used in mixed version testing, see draft PR citusdata/citus#8369 Tested locally for 17.7 ``` make build-exttester-17.7 // in container ls /opt/citus-versions/v13.2.0/ citus.so citus_columnar.so citus_decoders citus_pgoutput.so citus_wal2json.so ``` Slight increase in the image size: ``` ghcr.io/citusdata/exttester 17.7-dev-15cd08f ae73e573b28d 7 seconds ago 3.02GB ghcr.io/citusdata/exttester 17.7-dev-076d6fb be3fc5177d09 3 minutes ago 3.05GB // from this PR ``` See related PR in citus repo, testing the dev image as well : citusdata/citus#8390
alperkocatas
approved these changes
Dec 30, 2025
Contributor
alperkocatas
left a comment
alperkocatas
left a comment
There was a problem hiding this comment.
Looks good to me. Any specific things that you need me to check? I guess it won't be practical to test this locally, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for loading citus and columnar so files from a different directory during tests.
usage:
CITUSLIBDIR=/tmp/opt/citus_versions/v13.2.1 make check-minimal
CITUSLIBDIR=/tmp/opt/citus_versions/v13.2.1 citus_tests/run_test.py columnar_create
Note to reviewer:
The sample test in build_and_test.yml will be removed before merge (using a dev image from citusdata/the-process#180).
It generates the following test, see logs in Checks tab.
[Build & Test / Test Citus Lib N-1 / PG17 - check-minimal - lib-v13.2.0 (pull_request)]