Enhance eventtype filtering in eventlistings with a drop-down#74
Enhance eventtype filtering in eventlistings with a drop-down#74thoni56 wants to merge 2 commits into
Conversation
This incorporates the simple change in civicrm#68 and adds selection based on names of event types.
|
Thanks - I tried this locally but just get a text box for event type, not the dropdown: |
|
Have you ensured that the copy of I'm not sure why the files in Anyway, without the changes also in At least I hope that is the cause for your installation not picking it up. Also, I would very much appreciate if you could help me out with how I could test this locally? This repo will not build into a normal Joomla extension that can be installed, and I haven't managed to figure out how to integrate this with a complete CiviCRM build either. So I hacked the sources of an existing install and then extracted those changes to create this PR. Would appreciate any and all help with doing that the correct way. |
|
INSTRUCTIONS for testing: Copy either the modified files or the contents of the |
|
I think this is great btw - yes please 👍 !! Note that we are currently doing some work on Joomla 5 (and 4) compatibility with various PRs to resolve legacy code references, e.g. #89 which would affect this file. We haven't yet agreed how to deal with the change in base classes, but I would really like to see this merged in and then we can fix it up along with the other custom field classes! |
|
|
||
| // Check to ensure this file is included in Joomla! | ||
| defined('_JEXEC') or die('Restricted access'); | ||
| class JFormFieldCiviEventTypes extends JFormField |
There was a problem hiding this comment.
See #95 for changes to remove unconditional reference to legacy base class (for J4+ compatibility). Please could you update this to match the changes made there?
| $eventTypes = $this->getEventTypes($groupIdForEventTypes); | ||
|
|
||
| $options = array(); | ||
| $options[] = JHTML::_('select.option', '', ''); // Add an empty first option |
There was a problem hiding this comment.
See #89 for changes to remove unconditional references to legacy class names. Please could you update this to match the changes made there?
3 participants
This incorporates the simple change in #64 and adds selection based on names of event types.