-
-
Notifications
You must be signed in to change notification settings - Fork 46
Enhance eventtype filtering in eventlistings with a drop-down #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thoni56
wants to merge
2
commits into
civicrm:master
Choose a base branch
from
thoni56:filter-event-listing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| <?php | ||
| /* | ||
| +--------------------------------------------------------------------+ | ||
| | CiviCRM version 5 | | ||
| +--------------------------------------------------------------------+ | ||
| | This file is a part of CiviCRM. | | ||
| | | | ||
| | CiviCRM is free software; you can copy, modify, and distribute it | | ||
| | under the terms of the GNU Affero General Public License | | ||
| | Version 3, 19 November 2007 and the CiviCRM Licensing Exception. | | ||
| | | | ||
| | CiviCRM is distributed in the hope that it will be useful, but | | ||
| | WITHOUT ANY WARRANTY; without even the implied warranty of | | ||
| | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. | | ||
| | See the GNU Affero General Public License for more details. | | ||
| | | | ||
| | You should have received a copy of the GNU Affero General Public | | ||
| | License and the CiviCRM Licensing Exception along | | ||
| | with this program; if not, contact CiviCRM LLC | | ||
| | at info[AT]civicrm[DOT]org. If you have questions about the | | ||
| | GNU Affero General Public License or the licensing of CiviCRM, | | ||
| | see the CiviCRM license FAQ at http://civicrm.org/licensing | | ||
| +--------------------------------------------------------------------+ | ||
| */ | ||
|
|
||
| // Retrieve list of CiviCRM events | ||
| // Active, current or future | ||
|
|
||
| // Check to ensure this file is included in Joomla! | ||
| defined('_JEXEC') or die('Restricted access'); | ||
| class JFormFieldCiviEventTypes extends JFormField | ||
| { | ||
|
|
||
| /** | ||
| * Element name | ||
| * | ||
| * @access protected | ||
| * @var string | ||
| */ | ||
| var $type = 'CiviEventTypes'; | ||
|
|
||
| protected function getInput() | ||
| { | ||
| $value = $this->value; | ||
| $name = $this->name; | ||
|
|
||
| // Initiate CiviCRM | ||
| define('CIVICRM_SETTINGS_PATH', JPATH_ROOT . '/' . 'administrator/components/com_civicrm/civicrm.settings.php'); | ||
| require_once CIVICRM_SETTINGS_PATH; | ||
|
|
||
| require_once 'CRM/Core/ClassLoader.php'; | ||
| CRM_Core_ClassLoader::singleton()->register(); | ||
|
|
||
| require_once 'CRM/Core/Config.php'; | ||
| $config = CRM_Core_Config::singleton(); | ||
|
|
||
| $groupIdForEventTypes = $this->getGroupIdForEventTypes(); | ||
|
|
||
| $eventTypes = $this->getEventTypes($groupIdForEventTypes); | ||
|
|
||
| $options = array(); | ||
| $options[] = JHTML::_('select.option', '', ''); // Add an empty first option | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See #89 for changes to remove unconditional references to legacy class names. Please could you update this to match the changes made there? |
||
| foreach ($eventTypes as $eventType) { | ||
| $options[] = JHTML::_('select.option', $eventType['value'], $eventType['label']); | ||
| } | ||
|
|
||
| return JHTML::_('select.genericlist', $options, $name, NULL, 'value', 'text', $value); | ||
| } | ||
|
|
||
| private function getEventTypes($groupIdForEventTypes) | ||
| { | ||
| $eventTypeResults = \Civi\Api4\OptionValue::get(TRUE) | ||
| ->addWhere('option_group_id', '=', $groupIdForEventTypes) | ||
| ->execute(); | ||
| return iterator_to_array($eventTypeResults); | ||
| } | ||
|
|
||
| private function getGroupIdForEventTypes() | ||
| { | ||
| $groupIdResults = \Civi\Api4\OptionGroup::get(TRUE) | ||
| ->addSelect('id') | ||
| ->addWhere('name', '=', 'event_type') | ||
| ->execute(); | ||
| $groupIdForEventTypes = current(iterator_to_array($groupIdResults))['id']; | ||
|
|
||
| return $groupIdForEventTypes; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #95 for changes to remove unconditional reference to legacy base class (for J4+ compatibility). Please could you update this to match the changes made there?