dev: add Eastwood linting #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some other Etaoin wip, I wanted to address some reflection warnings for new code and noticed we did not have any existing checks for reflection. I find Eastwood helps out with this nicely. In addition to reflection warnings, I also addressed some other issues Eastwood reported: - A booboo in a test assertion for `etaoin.unit.unit-test/test-chrome-profile`. Fixed! - URL constructors are deprecated, starting with JDK 20. I switched to using lambdaisland/uri. - it noticed `is` assert messages that were not obviously strings. I ^String type hinted the message generating fn. - it thought string `"always"` for a constant truthy looked suspicious. I switched to the more conventional `:always`. - several tests had empty assertions like `(is true "text found")` or `(is 1)`. Perhaps some linter once warned about a test without assertions? We don't have such a thing today, so I turfed these meaningless assertions. The unwritten assertion for these tests is that they do not throw an exception.
- add some kondo lib config brought in by kondo - git ignore .eastwood dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some other Etaoin wip, I wanted to address some reflection warnings for new code and noticed we did not have any existing checks for reflection. I find Eastwood helps out with this nicely.
In addition to reflection warnings, I also addressed some other issues Eastwood reported:
etaoin.unit.unit-test/test-chrome-profile.Fixed!
isassert messages that were not obviously strings. I ^String type hinted the message generating fn."always"for a constant truthy looked suspicious. I switched to the more conventional:always.(is true "text found")or(is 1).Perhaps some linter once warned about a test without assertions? We don't have such a thing today, so I turfed these meaningless assertions. The unwritten assertion for these tests is that they do not throw an exception.
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions
I have updated CHANGELOG.adoc with a description of the addressed issue.