Fix warnings not being printed during config parsing#1821
Merged
kickster97 merged 3 commits intomainfrom Mar 25, 2026
Merged
Conversation
f74386c to
fe6a296
Compare
viktorerlingsson
approved these changes
Mar 24, 2026
|
PR Review No issues found. The change from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
The
Logcalls inparse_sectionanddo_setup_parserwere silent becausesetup_loggerruns after config parsing. UseSTDERR.putsinstead, matching the existing pattern inparse_sni.HOW can this pull request be tested?
specs