Skip to content

Fix warnings not being printed during config parsing#1821

Merged
kickster97 merged 3 commits intomainfrom
fix/deprecation-warnings-stderr
Mar 25, 2026
Merged

Fix warnings not being printed during config parsing#1821
kickster97 merged 3 commits intomainfrom
fix/deprecation-warnings-stderr

Conversation

@kickster97
Copy link
Copy Markdown
Member

@kickster97 kickster97 commented Mar 19, 2026

WHAT is this pull request doing?

The Log calls in parse_section and do_setup_parser were silent because setup_logger runs after config parsing. Use STDERR.puts instead, matching the existing pattern in parse_sni.

HOW can this pull request be tested?

specs

@kickster97 kickster97 force-pushed the fix/deprecation-warnings-stderr branch from f74386c to fe6a296 Compare March 19, 2026 14:51
@cloudamqp cloudamqp deleted a comment from claude bot Mar 19, 2026
@cloudamqp cloudamqp deleted a comment from claude bot Mar 19, 2026
@kickster97 kickster97 marked this pull request as ready for review March 24, 2026 14:33
@kickster97 kickster97 requested a review from a team as a code owner March 24, 2026 14:33
@cloudamqp cloudamqp deleted a comment from claude bot Mar 25, 2026
@cloudamqp cloudamqp deleted a comment from claude bot Mar 25, 2026
@cloudamqp cloudamqp deleted a comment from claude bot Mar 25, 2026
@claude
Copy link
Copy Markdown

claude bot commented Mar 25, 2026

PR Review

No issues found.

The change from Log.warn to STDERR.puts during config parsing is sound — the logging system isn't configured yet at that point, so writing directly to stderr ensures warnings are actually visible. The tests correctly capture stderr via reopen, restore it in ensure, and clean up the temp file. File descriptors are properly managed (dup, reopen, close).

@kickster97 kickster97 merged commit 9aa3117 into main Mar 25, 2026
18 of 20 checks passed
@kickster97 kickster97 deleted the fix/deprecation-warnings-stderr branch March 25, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants