Skip to content

Fix warnings not being printed during config parsing #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kickster97 merged 3 commits into from
Mar 25, 2026
Merged

Fix warnings not being printed during config parsing #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe6a296
Fix warnings not being printed during config parsing
kickster97 Mar 19, 2026
787b9a6
fix spec
kickster97 Mar 19, 2026
cc55e87
amend fd leak and ensure stderr_file is deleted
kickster97 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions spec/config_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,12 +440,22 @@ describe LavinMQ::Config do
default_password = +pHuxkR9fCyrrwXjOD4BP4XbzO3l8LJr8YkThMgJ0yVHFRE+
CONFIG
end
logs = Log.capture(level: :info) do
stderr_file = File.tempfile("stderr")
old_stderr = STDERR.dup
file = File.open(stderr_file.path, "w")
begin
STDERR.reopen(file)
config = LavinMQ::Config.new
argv = ["-c", config_file.path]
config.parse(argv)
ensure
STDERR.reopen(old_stderr)
old_stderr.close
file.close
end
logs.check(:warn, /is deprecated/)
File.read(stderr_file.path).should match(/is deprecated/)
ensure
stderr_file.try &.delete
end

it "should log warning for cli options" do
Expand All @@ -454,12 +464,22 @@ describe LavinMQ::Config do
[main]
CONFIG
end
logs = Log.capture(level: :info) do
stderr_file = File.tempfile("stderr")
old_stderr = STDERR.dup
file = File.open(stderr_file.path, "w")
begin
STDERR.reopen(file)
config = LavinMQ::Config.new
argv = ["-c", config_file.path, "--default-password", "8Yw8kj5HkhfRxQ/3kbTAO/nmgqGpkvMsGDbUWXA6+jTF3JP3"]
config.parse(argv)
ensure
STDERR.reopen(old_stderr)
old_stderr.close
file.close
end
logs.check(:warn, /is deprecated/)
File.read(stderr_file.path).should match(/is deprecated/)
ensure
stderr_file.try &.delete
end

it "should forward ini option values to the new property" do
Expand Down
8 changes: 4 additions & 4 deletions src/lavinmq/config.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,15 @@ module LavinMQ
{% for var in ivars_in_section %}
when "{{var[:ini_name]}}"
{% if (deprecated = var[:deprecated]) %}
Log.warn { "Config {{var[:ini_name]}} is deprecated, use {{deprecated.id}} instead" }
STDERR.puts "WARNING: Config {{var[:ini_name]}} is deprecated, use {{deprecated.id}} instead"
{% end %}
self.{{var[:var_name]}} = parse_value(v, {{var[:transform]}})
{% end %}
else
Log.warn { "Unknown setting #{name} in section {{section.id}}" }
STDERR.puts "WARNING: Unknown setting '#{name}' in section [{{section.id}}]"
end
rescue ex
Log.error { "Failed to handle value for '#{name}' in [{{section.id}}]: #{ex.message}" }
STDERR.puts "ERROR: Failed to handle value for '#{name}' in [{{section.id}}]: #{ex.message}"
abort
end
{% end %}
Expand Down Expand Up @@ -363,7 +363,7 @@ module LavinMQ
private def do_setup_parser(parser, *args)
parser.on(*args) do |val|
if msg = @deprecation_warn_msg
Log.warn { msg }
STDERR.puts "WARNING: #{msg}"
end
@set_value.call(val)
end
Expand Down
Loading