Fix: handle valueless boolean CLI flags at compile time#1842
Merged
kickster97 merged 2 commits intomainfrom Apr 8, 2026
Merged
Fix: handle valueless boolean CLI flags at compile time#1842kickster97 merged 2 commits intomainfrom
kickster97 merged 2 commits intomainfrom
Conversation
Member
|
Try @[CliOpt("", "--clustering", "Enable clustering", ->(String) { true }, section: "clustering")] |
|
No issues found. The fix correctly uses explicit Proc value parsers for the three valueless boolean CLI flags ( |
Member
Author
Think that makes for a better solution! |
viktorerlingsson
approved these changes
Apr 7, 2026
snichme
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Valueless boolean CLI flags like
--clusteringand--raise-gc-warnare broken.OptionParserpasses an empty string for flags without=VALUE, andparse_value("", Bool)evaluates tofalseinstead oftrue.Fixed by detecting valueless boolean flags at compile time in the
parse_climacro and assigning the correct literal (true, orfalsefor --no- prefixed flags) instead of always going throughparse_value.maybe this code is a bit clunky? I'd love to discuss if there are more elegant solutions
HOW can this pull request be tested?
run updated specs