Skip to content

Fix: handle valueless boolean CLI flags at compile time #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kickster97 merged 2 commits into from
Apr 8, 2026
Merged

Fix: handle valueless boolean CLI flags at compile time #1842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
437a5e9
assign boolean directly for valueless CLI flags instead of parsing em…
kickster97 Apr 7, 2026
303b7c1
use proc value parsers for valueless CLI boolean flags
kickster97 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions spec/config_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,8 @@ describe LavinMQ::Config do
"--default-user=cliuser",
"--default-user-only-loopback=false",
"--no-data-dir-lock",
"--clustering",
"--raise-gc-warn",
"--clustering-advertised-uri=lavinmq://test:5679",
"--clustering-bind=0.0.0.0",
"--clustering-etcd-endpoints=etcd1:2379,etcd2:2379",
Expand Down Expand Up @@ -317,6 +319,8 @@ describe LavinMQ::Config do
config.default_user.should eq "cliuser"
config.default_user_only_loopback?.should be_false
config.data_dir_lock?.should be_false
config.clustering?.should be_true
config.raise_gc_warn?.should be_true
config.clustering_advertised_uri.should eq "lavinmq://test:5679"
config.clustering_bind.should eq "0.0.0.0"
config.clustering_etcd_endpoints.should eq "etcd1:2379,etcd2:2379"
Expand Down
6 changes: 3 additions & 3 deletions src/lavinmq/config/options.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,14 +255,14 @@ module LavinMQ
@[IniOpt(section: "main", deprecated: "default_user_only_loopback")]
property? guest_only_loopback : Bool = true

@[CliOpt("", "--no-data-dir-lock", "Don't put a file lock in the data directory (default true)", section: "options")]
@[CliOpt("", "--no-data-dir-lock", "Don't put a file lock in the data directory (default true)", ->(_v : String) { false }, section: "options")]
@[IniOpt(section: "main")]
property? data_dir_lock : Bool = true

@[CliOpt("", "--raise-gc-warn", "Raise on GC warnings", section: "options")]
@[CliOpt("", "--raise-gc-warn", "Raise on GC warnings", ->(_v : String) { true }, section: "options")]
property? raise_gc_warn : Bool = false

@[CliOpt("", "--clustering", "Enable clustering", section: "clustering")]
@[CliOpt("", "--clustering", "Enable clustering", ->(_v : String) { true }, section: "clustering")]
@[IniOpt(ini_name: enabled, section: "clustering")]
@[EnvOpt("LAVINMQ_CLUSTERING")]
property? clustering = false
Expand Down
Loading