Remove unecessary entra_id_login variable validation - #87
Merged
rswrz merged 4 commits intoSep 17, 2025
Merged
Conversation
added 4 commits
September 16, 2025 11:47
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
rswrz
requested review from
Phil-Thoennissen,
lixhunter and
neonwhiskers
as code owners
September 16, 2025 10:03
2 tasks
lixhunter
approved these changes
Sep 17, 2025
rswrz
deleted the
84-feature-request-activate-entra-id-login-with-separate-role-assignments
branch
September 17, 2025 07:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #84 by removing the unnecessary variable validation that restricted Entra ID extension installation when no principal_id was defined via input variable.
PR Checklist
breaking-change,feature,fix,other,ignore-releaseMotivation and Context
Previously, the extension could not be installed unless a principal_id was explicitly provided. This restriction was technically unnecessary and limited flexibility. With this change, the extension can now be used without requiring a user or admin to be specified.
Breaking Changes