MTC worker: validate bootstrap certs #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
This is logic that bootstrap MTC clients will need to implement, but only really useful for testing here. |
added 11 commits
September 16, 2025 17:49
rozbb
force-pushed
the
mtc-validate-bootstrap-certs
branch
from
04d0763 to
620f885
Compare
rozbb
commented
Sep 16, 2025
Contributor
Author
rozbb
left a comment
rozbb
left a comment
There was a problem hiding this comment.
Rebased. Picked up one odd change
Contributor
Author
|
Fixed TODO on |
lukevalenta
requested changes
Sep 18, 2025
lukevalenta
reviewed
Sep 19, 2025
lukevalenta
reviewed
Sep 19, 2025
rozbb
commented
Sep 22, 2025
lukevalenta
approved these changes
Sep 25, 2025
Contributor
lukevalenta
left a comment
lukevalenta
left a comment
There was a problem hiding this comment.
Just some minor nits, but this looks good!
lukevalenta
reviewed
Sep 25, 2025
lukevalenta
reviewed
Sep 25, 2025
lukevalenta
reviewed
Sep 25, 2025
| .into(); | ||
| } else { | ||
| issuer_key_hash = Sha256::digest( | ||
| intermediates[0] |
Contributor
There was a problem hiding this comment.
I think here we're not guaranteed that intermediates[0] exists, so might need to grab the found root.
lukevalenta
reviewed
Sep 25, 2025
lukevalenta
approved these changes
Sep 25, 2025
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
validate_chainfunction in the Merkle Tree Certificate worker does not verify signatures on the provided bootstrap certificate chain (#109). This is not a security issue, but it does mean the log can get spammed easier because it will put obviously bad certificates on the log.This PR:
static_ct_apitox509_utilstatic_ct_apiandmtc_workergive to the generic validatorOne question I had: what precisely is
validate_correspondence()exposed for? I didn't implement validation there because it had a slightly different type signature, and it didn't look like it was used anywhere. I can def add it if it's needed though.