Migrate tests from unstable_dev() to unstable_startWorker() #12053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate fixtures/local-mode-tests (5 test files) to use unstable_startWorker
- Migrate fixtures/no-bundle-import to use unstable_startWorker
- Delete fixtures/unstable_dev/ (only existed to test the deprecated API)
- Delete packages/wrangler/src/__tests__/api-dev.test.ts (deprecated API tests)
- Remove unstable_dev() test block from e2e/dev-registry.test.ts
- Remove unused Unstable_DevWorker imports from get-platform-proxy tests
- Remove unstable_dev label from auto-assign-issues.ts
Key API changes in migrated tests:
- unstable_dev(path, opts) → unstable_startWorker({ entrypoint: path, ...opts })
- vars: { KEY: val } → bindings: { KEY: { type: 'plain_text', value: val } }
- worker.stop() → worker.dispose()
- worker.fetch('/path') → worker.fetch('http://example.com/path')
…t-pool-workers - Replace unstable_dev() with @cloudflare/vitest-pool-workers - Use SELF.fetch() for testing the worker - Use vi.spyOn(globalThis, 'fetch') to mock outbound requests to remote worker - Configure isolatedStorage: false to preserve KV state between tests - Add resolve.alias to fix promjs broken package.json (main points to lib/index.js but files are at root) - Update tests/tsconfig.json with vitest-pool-workers types All 25 tests pass.
- Migrate middleware.test.ts (26 tests) - Migrate middleware.scheduled.test.ts (10 tests) - Delete unused templates/init-tests/ directory (dead code)
|
penalosa
commented
Jan 22, 2026
Comment on lines
23
to
24
| // Let other requests pass through (e.g., prometheus logging) | ||
| // In tests, we don't want these to fail |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| // Let other requests pass through (e.g., prometheus logging) | |
| // In tests, we don't want these to fail |
penalosa
commented
Jan 22, 2026
Comment on lines
84
to
86
| vi.spyOn(globalThis, "fetch").mockImplementation( | ||
| createMockFetchImplementation() | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This should be in a beforeEach()
penalosa
commented
Jan 22, 2026
Comment on lines
75
to
79
| beforeAll(() => { | ||
| vi.spyOn(globalThis, "fetch").mockImplementation( | ||
| createMockFetchImplementation() | ||
| ); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Get rid of this and use beforeEach()
penalosa
commented
Jan 22, 2026
Comment on lines
310
to
312
| vi.spyOn(globalThis, "fetch").mockImplementation( | ||
| createMockFetchImplementation() | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
As above, use a beforeEach
penalosa
commented
Jan 22, 2026
Comment on lines
301
to
303
| beforeAll(() => { | ||
| vi.spyOn(globalThis, "fetch").mockImplementation( | ||
| createMockFetchImplementation() |
Contributor
Author
There was a problem hiding this comment.
Do you really need this again? The remote is the same as the one above
penalosa
commented
Jan 22, 2026
| origin: "https://cloudflare.dev", | ||
| "X-CF-Token": token, | ||
| "X-CF-Remote": `http://127.0.0.1:${remote.port}`, | ||
| "X-CF-Remote": `${MOCK_REMOTE_URL}`, |
Contributor
Author
There was a problem hiding this comment.
This template stirng is overkill
penalosa
commented
Jan 22, 2026
| origin: "https://cloudflare.dev", | ||
| "X-CF-Token": token, | ||
| "X-CF-Remote": `http://127.0.0.1:${remote.port}`, | ||
| "X-CF-Remote": `${MOCK_REMOTE_URL}`, |
Contributor
Author
There was a problem hiding this comment.
This template string is overkill
penalosa
commented
Jan 22, 2026
| origin: "https://cloudflare.dev", | ||
| "X-CF-Token": token, | ||
| "X-CF-Remote": `http://127.0.0.1:${remote.port}`, | ||
| "X-CF-Remote": `${MOCK_REMOTE_URL}`, |
Contributor
Author
There was a problem hiding this comment.
This template string is overkill
penalosa
commented
Jan 22, 2026
| origin: "https://cloudflare.dev", | ||
| "X-CF-Token": token, | ||
| "X-CF-Remote": `http://127.0.0.1:${remote.port}`, | ||
| "X-CF-Remote": `${MOCK_REMOTE_URL}`, |
Contributor
Author
There was a problem hiding this comment.
Okay, get rid of any and all redudant template strings
penalosa
commented
Jan 22, 2026
penalosa
commented
Jan 22, 2026
Comment on lines
19
to
25
| // promjs has broken package.json (main points to lib/index.js but files are at root) | ||
| resolve: { | ||
| alias: { | ||
| promjs: path.resolve(__dirname, "node_modules/promjs/index.js"), | ||
| }, | ||
| }, | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Is this needed? Did you have a look at the recommended SSR optimisations for vitest-pool-workers from the docs? Can you apply that to promjs?
penalosa
commented
Jan 22, 2026
| import * as fs from "node:fs"; | ||
| import { beforeEach, describe, expect, it, vi } from "vitest"; | ||
| import { unstable_dev } from "../api"; | ||
| import { startWorker as unstable_startWorker } from "../api/startDevWorker"; |
Contributor
Author
There was a problem hiding this comment.
Just import it as startWorker
penalosa
commented
Jan 22, 2026
| import dedent from "ts-dedent"; | ||
| import { beforeEach, describe, expect, it, vi } from "vitest"; | ||
| import { unstable_dev } from "../api"; | ||
| import { startWorker as unstable_startWorker } from "../api/startDevWorker"; |
Contributor
Author
There was a problem hiding this comment.
Just import it as startWorker
penalosa
commented
Jan 22, 2026
Comment on lines
1080
to
1084
| // Note: worker.fetch() doesn't work correctly with paths when | ||
| // EXPERIMENTAL_MIDDLEWARE=true is set. The request URL pathname gets | ||
| // lost, causing the worker to not match routes like "/setup". | ||
| // We use native fetch() with the worker URL as a workaround. | ||
| // See: https://github.com/cloudflare/workers-sdk/issues/XXXX |
Contributor
Author
There was a problem hiding this comment.
Change this to a TODO comment. We should get to the bottom of it
- Use beforeEach instead of beforeAll + afterEach re-mock pattern - Remove redundant template strings for MOCK_REMOTE_URL - Remove unnecessary comment about prometheus logging - Use @cloudflare/vitest-pool-workers/latest in tsconfig - Import startWorker directly instead of aliasing - Change worker.fetch() workaround comment to TODO
penalosa
changed the title
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
- Fix unused imports in dev-registry.test.ts - Fix RequestInfo type to Request | string | URL - Exclude vitest.config.mts from tsconfig type checking
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates tests away from the deprecated
unstable_dev()API to use eitherunstable_startWorker()orvitest-pool-workers.fixtures/integration tests tounstable_startWorker()edge-preview-authenticated-proxytovitest-pool-workersmiddleware.test.tsandmiddleware.scheduled.test.tstounstable_startWorker()templates/init-tests/directory (dead code using old API)