fix(wrangler): show friendly error when D1 export output is a directory #12065
Conversation
🦋 Changeset detectedLatest commit: 7d47f29 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Improves wrangler d1 export by replacing a low-level Node.js EISDIR error with a friendlier UserError when --output points to a directory.
Changes:
- Added a preflight
--outputpath check intended to detect directory paths and throw a descriptiveUserError. - Updated a comment spelling in the local export implementation.
- Added a changeset for a patch release of
wrangler.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/wrangler/src/d1/export.ts | Adds --output directory detection to produce a friendly error message before attempting to write. |
| .changeset/cute-pets-fry.md | Records the user-facing change in a patch changeset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| try { | ||
| const stats = await fs.stat(output); | ||
| if (stats.isDirectory()) { | ||
| throw new UserError( | ||
| `Please specify a file path for --output, not a directory.` | ||
| ); |
There was a problem hiding this comment.
There are existing automated tests for wrangler d1 export (e.g. packages/wrangler/src/__tests__/d1/export.test.ts), so this new directory-validation behavior should be covered with a test (create a directory, pass it as --output, and assert the friendly UserError message).
1 participant
Fixes #7629
Currently, when running
wrangler d1 exportwith a directory path passed to the--outputflag, it throws a low-level Node.jsEISDIRerror. This PR adds a check to verify if the provided output path is a directory and throws a descriptiveUserErrorinstead.pnpm run dev.node ./bin/wrangler.js d1 export <db-name> --output ./(with a dummy wrangler.toml).✘ [ERROR] Please specify a file path for --output, not a directory.A picture of a cute animal