Skip to content

fix(wrangler): show friendly error when D1 export output is a directory #12065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
langningchen wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(wrangler): show friendly error when D1 export output is a directory #12065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
939f9ce
fix(export): correct spelling
langningchen Jan 23, 2026
cd5a26f
fix(wrangler): validate output path to ensure it's a file, not a dire…
langningchen Jan 23, 2026
7d47f29
fix(export): improve error handling for output path validation
langningchen Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cute-pets-fry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Added friendly error message when D1 export output is a directory
15 changes: 14 additions & 1 deletion packages/wrangler/src/d1/export.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,19 @@ export const d1ExportCommand = createCommand({
throw new UserError(`You cannot specify both --no-schema and --no-data`);
}

try {
const stats = await fs.stat(output);
if (stats.isDirectory()) {
throw new UserError(
`Please specify a file path for --output, not a directory.`
);
Comment on lines +85 to +90
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are existing automated tests for wrangler d1 export (e.g. packages/wrangler/src/__tests__/d1/export.test.ts), so this new directory-validation behavior should be covered with a test (create a directory, pass it as --output, and assert the friendly UserError message).

Copilot uses AI. Check for mistakes.
}
} catch (e) {
if (e instanceof UserError) {
throw e;
}
}

// Allow multiple --table x --table y flags or none
const tables: string[] = table
? Array.isArray(table)
Expand Down Expand Up @@ -114,7 +127,7 @@ async function exportLocal(

const id = localDB.previewDatabaseUuid ?? localDB.uuid;

// TODO: should we allow customising persistence path?
// TODO: should we allow customizing persistence path?
// Should it be --persist-to for consistency (even though this isn't persisting anything)?
const persistencePath = getLocalPersistencePath(undefined, config);
const d1Persist = path.join(persistencePath, "v3", "d1");
Expand Down