refactor(wrangler): convert containers and cloudchamber commands to createCommand #12071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
5 tasks
petebacondarwin
force-pushed
the
pbd/wrangler/telemetry-event-refactor
branch
from
be3fd85 to
e0829f5
Compare
…reateCommand Migrate containers and cloudchamber CLI commands from the legacy yargs defineCommand approach to the new createCommand pattern. This aligns these commands with the updated telemetry handling where events are dispatched directly from command handlers rather than middleware.
petebacondarwin
force-pushed
the
pbd/wrangler/migrate-containers-to-define-command
branch
from
a073093 to
db843d1
Compare
Thanks to @vicb's feedback on GitHub, this: - Adds printBanner behaviour to suppress the Wrangler version banner in non-interactive/CI mode and when using --json flag - Adds hidden:false to all cloudchamber child commands/namespaces to override the inherited hidden:true from cloudchamberNamespace, which was preventing COMMANDS from showing in --help output
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
After feedback from Devin AI review, this adds the missing behaviour.printBanner configuration to containersImagesListCommand and containersImagesDeleteCommand to match their cloudchamber equivalents. This ensures the banner is suppressed when using --json flag or in non-interactive/CI environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate containers and cloudchamber CLI commands from the legacy yargs defineCommand approach to the new createCommand pattern. This aligns these commands with the updated telemetry handling where events are dispatched directly from command handlers rather than middleware.
Builds on top of #12069
A picture of a cute animal (not mandatory, but encouraged)