Skip to content

chore: create workflows merge from master to develop and check commits #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 3, 2025
Merged

chore: create workflows merge from master to develop and check commits #5611

merged 4 commits into from
Feb 3, 2025

Conversation

kkdy21
Copy link
Contributor

@kkdy21 kkdy21 commented Feb 3, 2025

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 5:21am
dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 5:21am
inventory-v2 ⬜️ Ignored (Inspect) Feb 3, 2025 5:21am

@github-actions github-actions bot added pass/signedoff pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. labels Feb 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

🎉 @piggggggggy and @Hansoo-mzc have been randomly selected as the reviewers! Please review. 🙏

@github-actions github-actions bot requested a review from Hansoo-mzc February 3, 2025 00:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ There are no commits in this PR that require review.

WANZARGEN
WANZARGEN approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@WANZARGEN WANZARGEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!
question: Curious how you resolved the input reflection issue when switching to workflow dispatch. Also, please check my minor suggestions about conventions. Ready to merge after your response!

@github-actions github-actions bot added approved/review Pull Request has been approved. All reviewers have signed off and no further changes are required. and removed pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. labels Feb 3, 2025
@kkdy21
Copy link
Contributor Author

kkdy21 commented Feb 3, 2025

✅ LGTM! question: Curious how you resolved the input reflection issue when switching to workflow dispatch. Also, please check my minor suggestions about conventions. Ready to merge after your response!

After re-reading the documentation for workflow_dispatch and checking my code, I found a problem with my code :(
Here are the relevant official document of github api
workflow_dispatch : https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event
repository_dispatch : https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#create-a-repository-dispatch-event

@kkdy21
chore: workflow name
e9da526 
Signed-off-by: daeyeon ko <[email protected]>
@github-actions github-actions bot added the pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. label Feb 3, 2025
@kkdy21 kkdy21 merged commit b50f1b8 into master Feb 3, 2025
8 checks passed
@github-actions github-actions bot removed pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. approved/review Pull Request has been approved. All reviewers have signed off and no further changes are required. labels Feb 3, 2025
sulmoJ added a commit to sulmoJ/console that referenced this pull request Feb 4, 2025
@sulmoJ
Revert "chore: create workflows merge from master to develop and chec…
38253b9 
…k commits (cloudforet-io#5611)"

This reverts commit b50f1b8.
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Merged
3 tasks
sulmoJ added a commit that referenced this pull request Feb 4, 2025
@sulmoJ
Revert "chore: create workflows merge from master to develop and chec…
b876ebb 
…k commits (#5611)" (#5615)

* Revert "chore: fix syntex error"

This reverts commit b57d020.

* Revert "chore: create workflows merge from master to develop and check commits (#5611)"

This reverts commit b50f1b8.

Signed-off-by: sulmo <[email protected]>
@WANZARGEN WANZARGEN deleted the feat-workflow-merge-and-comment branch February 17, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WANZARGEN WANZARGEN WANZARGEN approved these changes

@sulmoJ sulmoJ Awaiting requested review from sulmoJ

@piggggggggy piggggggggy Awaiting requested review from piggggggggy

@Hansoo-mzc Hansoo-mzc Awaiting requested review from Hansoo-mzc

Assignees
No one assigned
Labels
pass/signedoff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkdy21 @WANZARGEN