Skip to content

Fixes for the pipeline #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Fixes for the pipeline #3731

wants to merge 16 commits into from

Conversation

joergdw
Copy link
Contributor

@joergdw joergdw commented Apr 24, 2025

Brings in following fixes:

  • Adapt targets called from the pipeline to the changes in Makefiles as part of PR Clean-up Makefiles #3687.
  • Auto-login to the os-concourse-instance if the required concourse-target via concourse login has not been defined already.
  • Refactoring of the login across Makefile and devbox-hook.

Additionally this PR introduces devbox-based tooling-images as originally planned in PR #2943.

with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Extract metadata (tags, labels) for Docker
id: meta
uses: docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804 # v5
uses: docker/metadata-action@v5
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-${{ matrix.image_suffix }}

- name: Get ginkgo version from autoscaler-release
id: ginkgo
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2028:info:2:6: echo may not expand escape sequences. Use printf [shellcheck]

version=$(devbox info ginkgo | head --lines=1 | cut --field=2 --delimiter=" ")
echo "GINKGO version from devbox: '${version}'"
version=$(grep "ginkgo " .tool-versions| cut -f 2 -d " ")
echo "GINKGO version from .tool-versions: \'${version}\'"
echo "version=${version}" >> "$GITHUB_OUTPUT"

- id: get-golang-version
shell: bash
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2028:info:2:6: echo may not expand escape sequences. Use printf [shellcheck]

"store_path": "/nix/store/hgybbbzg778wasmw5g1hzm7a8n4wwd5h-glibc-locales-2.40-66"
}
}
},
"[email protected]": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint-fix] reported by reviewdog 🐶

Suggested change
"[email protected]": {
"github:NixOS/nixpkgs/nixpkgs-unstable": {
"last_modified": "2025-04-30T07:41:21Z",
"resolved": "github:NixOS/nixpkgs/423d2df5b04b4ee7688c3d71396e872afa236a89?lastModified=1745998881&narHash=sha256-vonyYAKJSlsX4n9GCsS0pHxR6yCrfqBIuGvANlkwG6U%3D"
},
"glibcLocales@latest": {
"last_modified": "2025-03-11T17:52:14Z",
"resolved": "github:NixOS/nixpkgs/0d534853a55b5d02a4ababa1d71921ce8f0aee4c#glibcLocales",
"source": "devbox-search",
"version": "2.40-66",
"systems": {
"aarch64-linux": {
"outputs": [
{
"name": "out",
"path": "/nix/store/iv7avlnmk2cx79xpi4mr8sk1kxvlvm9l-glibc-locales-2.40-66",
"default": true
}
],
"store_path": "/nix/store/iv7avlnmk2cx79xpi4mr8sk1kxvlvm9l-glibc-locales-2.40-66"
},
"x86_64-linux": {
"outputs": [
{
"name": "out",
"path": "/nix/store/hgybbbzg778wasmw5g1hzm7a8n4wwd5h-glibc-locales-2.40-66",
"default": true
}
],
"store_path": "/nix/store/hgybbbzg778wasmw5g1hzm7a8n4wwd5h-glibc-locales-2.40-66"
}
}
},
"[email protected]": {

Copy link

@@ -68,10 +72,10 @@ debug "SYSTEM_DOMAIN: ${SYSTEM_DOMAIN}"
system_domain="${SYSTEM_DOMAIN}"

BBL_STATE_PATH="${BBL_STATE_PATH:-$( realpath -e "${root_dir}/../app-autoscaler-env-bbl-state/bbl-state" 2> /dev/null || echo "${root_dir}/../bbl-state/bbl-state" )}"
BBL_STATE_PATH="$(realpath -e "${BBL_STATE_PATH}" || echo "ERR_invalid_state_path" )"
BBL_STATE_PATH="$(realpath --canonicalize-existing "${BBL_STATE_PATH}" \
|| echo 'ERR_invalid_state_path, please set ${BBL_STATE_PATH}' )"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Expressions don't expand in single quotes, use double quotes for that. SC2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant