Fixes for the pipeline #3731
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,20 +5,55 @@ on: | |
| paths: | ||
| - 'ci/dockerfiles/**' | ||
| - '.github/workflows/image.yml' | ||
| - '.tool-versions' | ||
| pull_request: | ||
| paths: | ||
| - 'ci/dockerfiles/**' | ||
| - '.github/workflows/image.yml' | ||
| - '.tool-versions' | ||
| workflow_dispatch: | ||
|
|
||
| env: | ||
| REGISTRY: ghcr.io | ||
| jobs: | ||
| build-and-push-devbox-image: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| packages: write | ||
| name: Build and Push app-autoscaler-release-devbox | ||
| env: | ||
| IMAGE_NAME: ${{ github.repository }}-devbox | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Log in to the Container registry | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Extract metadata (tags, labels) for Docker | ||
| id: meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} | ||
|
|
||
| - name: Build and push | ||
| id: build-and-push | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . | ||
| file: ci/dockerfiles/autoscaler-devbox/Dockerfile | ||
| push: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| cache-from: type=registry,ref=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:main | ||
|
|
||
| build-and-push-image: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| packages: write | ||
|
|
@@ -29,40 +64,42 @@ jobs: | |
| matrix: | ||
| image_suffix: ["tools"] | ||
| name: Build and Push app-autoscaler-release-${{ matrix.image_suffix }} | ||
| env: | ||
| IMAGE_NAME: ${{ github.repository }} | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Log in to the Container registry | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Extract metadata (tags, labels) for Docker | ||
| id: meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-${{ matrix.image_suffix }} | ||
|
|
||
| - name: Get ginkgo version from autoscaler-release | ||
| id: ginkgo | ||
| run: | | ||
| version=$(grep "ginkgo " .tool-versions| cut -f 2 -d " ") | ||
| echo "GINKGO version from .tool-versions: \'${version}\'" | ||
| echo "version=${version}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - id: get-golang-version | ||
| shell: bash | ||
| run: | | ||
|
There was a problem hiding this comment. 📝 [actionlint] reported by reviewdog 🐶 |
||
| version=$(grep "golang " .tool-versions| cut -f 2 -d " ") | ||
| echo "Go version from .tool-versions: \'${version}\'" | ||
| echo "version=${version}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Build and push | ||
| id: build-and-push | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: ci/dockerfiles/autoscaler-${{ matrix.image_suffix }} | ||
| push: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # ================================================================================ | ||
| # 🤖 Generated files | ||
| # ================================================================================ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| FROM jetpackio/devbox:latest | ||
|
|
||
| # Installing your devbox project | ||
| WORKDIR /code | ||
| USER root:root | ||
| RUN mkdir --parents /code && chown ${DEVBOX_USER}:${DEVBOX_USER} /code | ||
| USER ${DEVBOX_USER}:${DEVBOX_USER} | ||
| COPY --chown=${DEVBOX_USER}:${DEVBOX_USER} devbox.json devbox.json | ||
| COPY --chown=${DEVBOX_USER}:${DEVBOX_USER} devbox.lock devbox.lock | ||
|
|
||
|
|
||
| # # 💡 Here maybe the chown is missing! | ||
| # # Step 6: Copying local flakes directories | ||
| #COPY --chown=${DEVBOX_USER}:${DEVBOX_USER} ./.devbox/virtenv/mysql/flake ./.devbox/virtenv/mysql/flake | ||
| COPY --chown=${DEVBOX_USER}:${DEVBOX_USER} ./.devbox ./.devbox | ||
| COPY --chown=${DEVBOX_USER}:${DEVBOX_USER} ./nix ./nix | ||
|
|
||
| # 💡 The issue probably is, that we don't copy the necessary files before. | ||
| # I alternatively will try to avoid the copies and read-only-mount those directories | ||
| # into the image. | ||
| RUN \ | ||
| # --mount=type=bind,source=./nix,target=/code/nix,readonly \ | ||
| # --mount=type=bind,source=./.devbox,target=/code/.devbox,readonly \ | ||
| <<-EODI | ||
| echo "ls -lah /code: $(ls -lah /code)" | ||
| echo "ls -lah /code/.devbox: $(ls -lah /code/.devbox)" | ||
| echo "ls -lah /code/.devbox/gen: $(ls -lah /code/.devbox/gen)" | ||
| devbox run -- echo "Installed Packages." | ||
| EODI | ||
|
|
||
| # Make use of the installed devbox-environment: | ||
| ENV \ | ||
| PATH="/code/.devbox/nix/profile/default/bin:${PATH}" \ | ||
| LD_LIBRARY_PATH="/code/.devbox/nix/profile/default/lib" | ||
|
|
||
| # 🚧 To-do: Check if “ENTRYPOINT” is not the better alternative, see: | ||
| # <https://www.bmc.com/blogs/docker-cmd-vs-entrypoint> | ||
| ENTRYPOINT ["devbox", "run", "--"] | ||
| # CMD ["devbox", "shell"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # ==================== Ignore everything by default ==================== | ||
| * | ||
|
|
||
|
|
||
|
|
||
| # ==================== What we actually need ==================== | ||
| !./nix | ||
| !/flake.nix | ||
| !/flake.lock | ||
|
|
||
| !./.devbox | ||
| !/devbox.json | ||
| !/devbox.lock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2028:info:2:6: echo may not expand escape sequences. Use printf [shellcheck]