Skip to content

Add files present in L1 Trigger Fork #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aloeliger
Copy link
Contributor

As part of the ongoing L1T effort to remove dependence on CMSSW/related directories running in parallel under L1T management with common de-synchronization problems, this PR adds LUT/data files found in our copy of the L1Trigger-L1TCalorimeter data directory to the central repository.

The ultimate drive of this relocation of data files is attempting to change how calorimeter parameter records are kept, so that ultimately they can be pointed at this directory to be kept accurate and up to date.

The total size of added files is 5.2 Mb.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2023

A new Pull Request was created by @aloeliger (Andrew Loeliger) for branch master.

@aandvalenzuela, @cmsbuild, @aloeliger, @epalencia, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-633bba/36000/summary.html
COMMIT: 7749ea1
CMSSW: CMSSW_14_0_X_2023-11-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-L1TCalorimeter/24/36000/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-633bba/36000/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-633bba/36000/git-merge-result

Comparison Summary

Summary:

  • You potentially added 931 lines to the logs
  • Reco comparison results: 18318 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363861
  • DQMHistoTests: Total failures: 24006
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3339830
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 388.4359999999999 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 141.044 ): 0.062 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 23234.0,... ): 41.775 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 23234.0,... ): 22.953 KiB HLT/Tracking
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@aloeliger , is there any cmssw change which uses these new data files?

@aloeliger
Copy link
Contributor Author

@smuzaffar Apologies, wrong information, I had the wrong PR. At this point I am still trying to sort out if any files in our fork, or the main fork use these while I try to wind down L1's use of this fork that accumulates unused, or un-merged files like this.

I can try to wind this PR down into something a bit more selective.

@aloeliger
Copy link
Contributor Author

@bundocka This is back on top of my TODO list. Do you know if any of these files are used for anything in CMSSW anymore? Any references in the calo params? Given that they were just sitting around in our data directory, I would guess they probably aren't that important, but could I ask you to take a 5 minute look and see if any definitely jump out at you as "Keep this and merge it into CMSSW"?

also @bundocka Since this has become a bit of a mess, to make sure that this causes minimum interruption, I am going to copy the ZDC LUTs back to our data directory as a temporary solution while I bring the caloparams cleaning, and this back onto my priority list.

@aloeliger
Copy link
Contributor Author

@bundocka Just FYI, I have copied the original ZDC LUT to our data directory, it should be present in both places while this gets worked out.

@smuzaffar
Copy link
Contributor

Should we close this in favor of #26?

@aloeliger
Copy link
Contributor Author

@smuzaffar I'll need to run some L1 emulator recipes on the next convenient release first, so I would prefer to keep this around until I've confirmed I've got the minimum working set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants