-
Notifications
You must be signed in to change notification settings - Fork 13
Add files present in L1 Trigger Fork #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add files present in L1 Trigger Fork #24
Conversation
A new Pull Request was created by @aloeliger (Andrew Loeliger) for branch master. @aandvalenzuela, @cmsbuild, @aloeliger, @epalencia, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-633bba/36000/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
@aloeliger , is there any cmssw change which uses these new data files? |
@smuzaffar Apologies, wrong information, I had the wrong PR. At this point I am still trying to sort out if any files in our fork, or the main fork use these while I try to wind down L1's use of this fork that accumulates unused, or un-merged files like this. I can try to wind this PR down into something a bit more selective. |
@bundocka This is back on top of my TODO list. Do you know if any of these files are used for anything in CMSSW anymore? Any references in the calo params? Given that they were just sitting around in our data directory, I would guess they probably aren't that important, but could I ask you to take a 5 minute look and see if any definitely jump out at you as "Keep this and merge it into CMSSW"? also @bundocka Since this has become a bit of a mess, to make sure that this causes minimum interruption, I am going to copy the ZDC LUTs back to our data directory as a temporary solution while I bring the caloparams cleaning, and this back onto my priority list. |
@bundocka Just FYI, I have copied the original ZDC LUT to our data directory, it should be present in both places while this gets worked out. |
Should we close this in favor of #26? |
@smuzaffar I'll need to run some L1 emulator recipes on the next convenient release first, so I would prefer to keep this around until I've confirmed I've got the minimum working set. |
As part of the ongoing L1T effort to remove dependence on CMSSW/related directories running in parallel under L1T management with common de-synchronization problems, this PR adds LUT/data files found in our copy of the L1Trigger-L1TCalorimeter data directory to the central repository.
The ultimate drive of this relocation of data files is attempting to change how calorimeter parameter records are kept, so that ultimately they can be pointed at this directory to be kept accurate and up to date.
The total size of added files is 5.2 Mb.