Skip to content

Add minimal data-file changes for current recipes #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

aloeliger
Copy link
Contributor

This PR adds in a minimal set of data-files required to run current 2023 L1Trigger emulation recipes without customizations. The current (failing) recipes these are intended to fix can be seen here: https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideL1TStage2Instructions

This PR should form a more minimal subset of the datafiles introduced in #24

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aloeliger (Andrew Loeliger) for branch master.

@smuzaffar, @epalencia, @cmsbuild, @aloeliger, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@thomreis, @wang0jin, @rchatter, @argiro, @ReyerBand this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 26, 2024

cms-bot internal usage

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bbb8f/37065/summary.html
COMMIT: ad00bc6
CMSSW: CMSSW_14_0_X_2024-01-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-L1TCalorimeter/26/37065/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor Author

+l1

@aloeliger
Copy link
Contributor Author

@smuzaffar @iarspider just a ping on this

@smuzaffar
Copy link
Contributor

+externals

only new data files.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@BenjaminRS
Copy link

@mandrenguyen can we have this merged please? We would then like to have new 2025 LUTs added into cms-data too

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bbb8f/45559/summary.html
COMMIT: ad00bc6
CMSSW: CMSSW_15_1_X_2025-04-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-L1TCalorimeter/26/45559/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 150 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3904465
  • DQMHistoTests: Total failures: 2919
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3901526
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 145.014 ): -14484.059 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 145.014 ): 13252.701 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 145.014 ): 10484.856 KiB HLT/EGM
  • DQMHistoSizes: changed ( 145.014 ): 10390.469 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 145.014 ): 9022.441 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 145.014 ): 4970.328 KiB HLT/BTV
  • DQMHistoSizes: changed ( 145.014 ): -3543.336 KiB Tracking/V0Monitoring
  • DQMHistoSizes: changed ( 145.014 ): 1760.164 KiB HLT/EXO
  • DQMHistoSizes: changed ( 145.014 ): -1162.402 KiB L1TEMU/L1TObjects
  • DQMHistoSizes: changed ( 145.014 ): -1160.753 KiB L1T/L1TObjects
  • DQMHistoSizes: changed ( 145.014 ): ...
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link

+1
@BenjaminRS sorry for the delay

@cmsbuild cmsbuild merged commit ee77ff6 into cms-data:master Apr 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants