Skip to content

Use TkPixelCPERecord for PixelCPEFastParams* #46852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Dec 3, 2024

PR description:

This PR proposes two three things:

  • to remove the PixelCPEFastParamsRecord;
  • write the PixelCPEFastParams in TkPixelCPERecord that is the record for all the other CPEs;
  • have the modules consuming PixelCPEFastParams use the TkPixelCPERecord.

When we ported the code to Alpaka we introduced PixelCPEFastParamsRecord without a specific reason but the fact that we were learning how to write an Alpaka ESProduct/ESProducer and it seemed natural to have it in a new record.

PR validation:

runTheMatrix.py -w upgrade -l 12834.402 runs.

@AdrianoDee
Copy link
Contributor Author

enable gpu

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

cms-bot internal usage

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relvals_gpu = 12834.402
  • relvals_gpu_opts = -w upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • RecoLocalTracker/Records (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoTracker/PixelSeeding (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @alesaggio, @dgulhan, @dkotlins, @echabert, @felicepantaleo, @ferencek, @gbenelli, @gpetruc, @jlidrych, @missirol, @mmusich, @mroguljic, @mtosi, @robervalwalsh, @rovere, @threus, @tsusa, @tvami, @yduhm this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee AdrianoDee marked this pull request as draft December 3, 2024 12:21
@AdrianoDee
Copy link
Contributor Author

Moved it to draft since this technically works for pixel tracks but I have to test if this works for refitting purposes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

@fwyzard
Copy link
Contributor

fwyzard commented Mar 21, 2025

test parameters:

@fwyzard
Copy link
Contributor

fwyzard commented Mar 21, 2025

enable gpu

@fwyzard
Copy link
Contributor

fwyzard commented Mar 21, 2025

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-CUDA
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea591c/45143/summary.html
COMMIT: 9bd4fde
CMSSW: CMSSW_15_1_X_2025-03-21-1100/el8_amd64_gcc12
Additional Tests: ROCM,CUDA
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46852/45143/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-CUDA

  • 12834.42312834.423_TTbar_14TeV+2024_Patatrack_HCALOnlyGPUandAlpaka_Validation/step2_TTbar_14TeV+2024_Patatrack_HCALOnlyGPUandAlpaka_Validation.log
  • 12834.42212834.422_TTbar_14TeV+2024_Patatrack_HCALOnlyAlpaka_Validation/step2_TTbar_14TeV+2024_Patatrack_HCALOnlyAlpaka_Validation.log
  • 12834.40612834.406_TTbar_14TeV+2024_Patatrack_PixelOnlyTripletsAlpaka/step2_TTbar_14TeV+2024_Patatrack_PixelOnlyTripletsAlpaka.log
Expand to see more relval errors ...

Comparison Summary

Summary:

ROCM Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53071
  • DQMHistoTests: Total failures: 939
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52132
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants