Skip to content

CA Extension to strips #47090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

CA Extension to strips #47090

wants to merge 10 commits into from

Conversation

bdanzi
Copy link

@bdanzi bdanzi commented Jan 13, 2025 •
edited
Loading

PR description:

This PR should introduce the usage of strips layers to the offline reco and HLT Cellular Automaton (CA) usage (work done in 15_0_0_pre1):

  • the strip addition and the changes in performance are expected only if using the customizer customizeHLTforAlpakaStrip for HLT and stripNTupletFit for offline reco, final geometry (Geometry/CommonTopologies/interface/SimplePixelStripTopology.py) pairs is still work in progress
  • little gain in performance for the CA applied to pixel only due to the removal of minYsizeB1 and minYsizeB2 cuts + generalization of Kernel_simpleTripletCleaner
    Test on TTbar PU EOR3 TRK DPG v7:
    http://uaf-3.t2.ucsd.edu/~bdanzi/plots_pixelsOnlyValidation_AllCases/plots_hlt_hltPixel/effandfakePtEtaPhi.png where results in blue and red are produced with a cleaned 14_2_0 CMSSW release while the black one comes along with this PR changes

PR validation:

Before submitting I was checking

  • basic test procedure suggested in the CMSSW PR instructions, some of them still failing with exception like:
A std::exception was thrown.
Connection on "frontier://(preferipfamily=0)(proxyconfigurl=http://grid-wpad/wpad.dat)(backupproxyurl=http://cmst0frontier.cern.ch:3128)(backupproxyurl\
=http://cmst0frontier1.cern.ch:3128)(backupproxyurl=http://cmst0frontier2.cern.ch:3128)(backupproxyurl=http://cmsbpfrontier.cern.ch:3128)(backupproxyur\
l=http://cmsbpfrontier1.cern.ch:3128)(backupproxyurl=http://cmsbpfrontier2.cern.ch:3128)(backupproxyurl=http://cmsbproxy.fnal.gov:3128)(serverurl=http:\
//cmsfrontier.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier1.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier2.cern.ch:8000/FrontierPr\
od)(serverurl=http://cmsfrontier3.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier4.cern.ch:8000/FrontierProd)/CMS_CONDITIONS" cannot be establi\
shed ( CORAL : "ConnectionPool::getSessionFromNewConnection" from "CORAL/Services/ConnectionService" )
----- End Fatal Exception -------------------------------------------------

cc @mmasciov @slava77
Work co-authored-by: @AdrianoDee Adriano Di Florio [email protected]

@cmsbuild cmsbuild changed the base branch from CMSSW_15_0_X to master January 13, 2025 09:47
@cmsbuild
Copy link
Contributor

bdanzi, CMSSW_15_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Jan 13, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47090/43269

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47090/43271

@cmsbuild
Copy link
Contributor

Pull request #47090 was updated.

@AdrianoDee
Copy link
Contributor

please test

This was referenced Feb 12, 2025
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 24, 2025
Merged
Merged
@cmsbuild cmsbuild mentioned this pull request Mar 4, 2025
Merged
@kpedro88
Copy link
Contributor

kpedro88 commented Mar 4, 2025

-geometry
(to remove from pending list)

This was referenced Mar 6, 2025
Merged
Merged
Merged
Draft
Merged
This was referenced Mar 17, 2025
Open
Merged
Merged
This was referenced Mar 25, 2025
Merged
Merged
Merged
This was referenced Apr 6, 2025
Merged
Merged
Open
This was referenced Apr 15, 2025
Merged
Open
Merged
@cmsbuild cmsbuild mentioned this pull request Apr 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwyzard fwyzard fwyzard left review comments

@Martin-Grunewald Martin-Grunewald Martin-Grunewald left review comments

@mmasciov mmasciov mmasciov left review comments

@mmusich mmusich mmusich left review comments

@VourMa VourMa VourMa left review comments

Assignees
No one assigned
Labels
allow-bdanzi changes-dataformats code-checks-approved dqm-pending geometry-rejected heterogeneous-rejected hlt-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending tests-rejected tracking trk upgrade-pending
Projects
None yet
Milestone
CMSSW_15_1_X
Development

Successfully merging this pull request may close these issues.