-
Notifications
You must be signed in to change notification settings - Fork 4.6k
add fillDescriptions to several ESproducers used at HLT (1/N)
#47136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ee2901b
add fillDescriptions to Phase2StripCPEESProducer
mmusich 4786be4
add a fillDescriptions for SteppingHelixPropagatorESProducer
mmusich be0ead1
add fillDescriptions to SmartPropagatorESProducer
mmusich 1f4a725
add a fillDescriptions generated cfi to KFUpdatorESProducer
mmusich f018a01
add an auto-generated cfi file for MuonTransientTrackingRecHitBuilder…
mmusich e2c0af7
add an auto-generated file for AnalyticalPropagatorESProducer
mmusich 1ee28db
add a fillDescriptions for SiStripRegionConnectivity
mmusich ad88f71
add fillDescriptions to StripCPEESProducer
mmusich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 5 additions & 4 deletions
9
CalibTracker/SiStripESProducers/python/SiStripRegionConnectivity_cfi.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| SiStripRegionConnectivity = cms.ESProducer("SiStripRegionConnectivity", | ||
| EtaDivisions = cms.untracked.uint32(20), | ||
| PhiDivisions = cms.untracked.uint32(20), | ||
| EtaMax = cms.untracked.double(2.5) | ||
| from CalibTracker.SiStripESProducers.siStripRegionConnectivity_cfi import siStripRegionConnectivity as _siStripRegionConnectivity | ||
| SiStripRegionConnectivity = _siStripRegionConnectivity.clone( | ||
| EtaDivisions = 20, | ||
| PhiDivisions = 20, | ||
| EtaMax = 2.5 | ||
| ) | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 4 additions & 6 deletions
10
RecoLocalTracker/Phase2TrackerRecHits/python/Phase2StripCPEESProducer_cfi.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| phase2StripCPEESProducer = cms.ESProducer("Phase2StripCPEESProducer", | ||
| ComponentType = cms.string('Phase2StripCPE'), | ||
| parameters = cms.PSet(LorentzAngle_DB = cms.bool(True), | ||
| TanLorentzAnglePerTesla = cms.double(0.07) | ||
| ) | ||
| ) | ||
| from RecoLocalTracker.Phase2TrackerRecHits.phase2StripCPEESProducer_cfi import phase2StripCPEESProducer as _phase2StripCPEESProducer | ||
| phase2StripCPEESProducer = _phase2StripCPEESProducer.clone(ComponentType = 'Phase2StripCPE', | ||
| parameters = dict(LorentzAngle_DB = True, | ||
| TanLorentzAnglePerTesla = 0.07)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 2 additions & 6 deletions
8
RecoMuon/TransientTrackingRecHit/python/MuonTransientTrackingRecHitBuilder_cfi.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,4 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| MuonTransientTrackingRecHitBuilderESProducer = cms.ESProducer("MuonTransientTrackingRecHitBuilderESProducer", | ||
| ComponentName = cms.string('MuonRecHitBuilder') | ||
| ) | ||
|
|
||
|
|
||
|
|
||
| from RecoMuon.TransientTrackingRecHit.muonTransientTrackingRecHitBuilderESProducer_cfi import muonTransientTrackingRecHitBuilderESProducer as _muonTransientTrackingRecHitBuilderESProducer | ||
| MuonTransientTrackingRecHitBuilderESProducer = _muonTransientTrackingRecHitBuilderESProducer.clone() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configs for SiStripRegionConnectivity are either set or linked in several other parts in CMSSW, see https://github.com/search?q=repo%3Acms-sw%2Fcmssw%20SiStripRegionConnectivity&type=code , and everywhere the parameters are set as in your CalibTracker/SiStripESProducers/python/SiStripRegionConnectivity_cfi.py : why are you defining as default parameters in the
fillDescriptionsmethod some different ones?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because these are the default values, as natively provided in the class:
cmssw/CalibTracker/SiStripESProducers/plugins/geom/SiStripRegionConnectivity.cc
Lines 37 to 39 in b72455a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point...