add fillDescriptions to several ESproducers used at HLT (1/N)

[mmusich]

PR description:

This PR is similar in spirit to #47017, #47045, #47079 and #47107. It adds fillDescriptions (and applies light modification to modernize the source code) to a few ESProducers used at HLT for both Run 3 and Phase 2.

PR validation:

• addOnTests.py runs fine.
• hltPhase2UpgradeIntegrationTests runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47136/43364

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalTracker/SiStripRecHitConverter/interface/StripCPEfromTrackAngle.h modified in PR(s): CA Extension to strips #47090
  • File RecoLocalTracker/SiStripRecHitConverter/src/StripCPEfromTrackAngle.cc modified in PR(s): Introduce vFloat and float types in ParameterSets #45216
  • File RecoMuon/TransientTrackingRecHit/plugins/MuonTransientTrackingRecHitBuilderESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/KalmanUpdators/plugins/KFUpdatorESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• CalibTracker/SiStripESProducers (alca)
• RecoLocalTracker/Phase2TrackerRecHits (reconstruction, upgrade)
• RecoLocalTracker/SiStripRecHitConverter (reconstruction)
• RecoMuon/TransientTrackingRecHit (reconstruction)
• TrackPropagation/SteppingHelixPropagator (reconstruction)
• TrackingTools/GeomPropagators (reconstruction)
• TrackingTools/KalmanUpdators (reconstruction)
• TrackingTools/Producers (reconstruction)

@Moanwar, @atpathak, @cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @VinInn, @VourMa, @abbiendi, @alesaggio, @andrea21z, @bellan, @cericeci, @dgulhan, @echabert, @felicepantaleo, @gbenelli, @gpetruc, @jhgoh, @jlidrych, @missirol, @mmusich, @mtosi, @robervalwalsh, @rociovilar, @rovere, @rsreds, @threus, @tocheng, @trocino, @yduhm, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a79817/43847/summary.html
COMMIT: ad88f71
CMSSW: CMSSW_15_0_X_2025-01-19-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47136/43847/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 41 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3932183
• DQMHistoTests: Total failures: 1275
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3930888
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

The configs for SiStripRegionConnectivity are either set or linked in several other parts in CMSSW, see https://github.com/search?q=repo%3Acms-sw%2Fcmssw%20SiStripRegionConnectivity&type=code , and everywhere the parameters are set as in your CalibTracker/SiStripESProducers/python/SiStripRegionConnectivity_cfi.py : why are you defining as default parameters in the fillDescriptions method some different ones?

[mmusich]

Because these are the default values, as natively provided in the class:

cmssw/CalibTracker/SiStripESProducers/plugins/geom/SiStripRegionConnectivity.cc

Lines 37 to 39 in b72455a

	: etadivisions_(pset.getUntrackedParameter<unsigned int>("EtaDivisions", 10)),
	phidivisions_(pset.getUntrackedParameter<unsigned int>("PhiDivisions", 10)),
	etamax_(pset.getUntrackedParameter<double>("EtaMax", 2.4))

[perrotta]

Good point...

[perrotta]

+alca

[jfernan2]

+1

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1