Skip to content

introduce @phase2FakeHLT and @phase2ValidationFakeHLT DQM / Validation sequences #47401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 19, 2025

PR description:

There are still few phase-2 geometries in release for which we don't run the HLT step. Thus the HLT DQM and validation sequences (and harvestings) get run without purpose. This lead e.g. to the issue described at #47352 (comment) in which wf 24034.0 (that runs the @fake2 menu) was trying to consume HLT collections that were not present on file.
This PR introduces a @phase2FakeHLT (DQM) and a @phase2ValidationFakeHLT (Validation) sequence that can be run in phase-2 workflows in which there is no intention to run the HLT step (similarly as for what is done in Run3).

PR validation:

  • runTheMatrix.py -l phase2 runs fine
  • runTheMatrix.py -l 24034.0 -t 4 -j 8 --ibeos runs fine (this is for a geometry in which we don't run )

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 19, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47401/43784

@mmusich
Copy link
Contributor Author

mmusich commented Feb 19, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 92KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c9af1/44505/summary.html
COMMIT: 03d0574
CMSSW: CMSSW_15_1_X_2025-02-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47401/44505/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • DQMOffline/Configuration (dqm)
  • Validation/Configuration (simulation, dqm)

@AdrianoDee, @Moanwar, @antoniovagnerini, @civanch, @DickyChant, @kpedro88, @mdhildreth, @miquork, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @apsallid, @denizsun, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @missirol, @mmusich, @mtosi, @rociovilar, @rovere, @salimcerci, @sameasy, @slomeo, @threus, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Feb 20, 2025

+1

@Moanwar
Copy link
Contributor

Moanwar commented Feb 21, 2025

+Upgrade

@mmusich
Copy link
Contributor Author

mmusich commented Feb 24, 2025

@cms-sw/pdmv-l2 @cms-sw/dqm-l2 kind ping.

@antoniovagnerini
Copy link

+dqm

@mmusich
Copy link
Contributor Author

mmusich commented Feb 25, 2025

@cms-sw/pdmv-l2 another kind ping

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Feb 25, 2025 via email

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5cacea5 into cms-sw:master Feb 25, 2025
11 checks passed
@mmusich mmusich deleted the phase2_DQM_Validation_noHLT branch February 25, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants