Skip to content

[NGT] Add a novel NGTScouting Phase-2 HLT menu that runs a single "scouting"-like path on the whole L1Accept #47434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 24, 2025

PR description:

The NGT project aims to complement the HLT event filtering approach in the Phase-2 HLT farm by performing offline-like full event reconstruction. This approach goes beyond traditional event selection by adopting a "scouting"-like strategy, processing the full L1Accept input and producing a lightweight nanoAOD-like output format. More details on the NGT project's methodology can be found here.

image

This PR introduces a new NGTScouting Phase-2 HLT menu, which runs a single DST_PFScouting path. This path performs full HLT event reconstruction without any HLT filtering, processing the entire set of events passing the logical OR of all available L1T seeds in the Phase-2 L1T reduced menu. The implementation serves as a foundational step towards creating a path that outputs the entire L1Accept bandwidth in nanoAOD format. The necessary infrastructure to finalize this output format will be addressed in a follow-up PR.

Furthermore, this PR adds a new family of runTheMatrix workflows, identified by the .77 modifier, to facilitate testing of the NGTScouting menu. These workflows will enable comprehensive validation and performance checks, ensuring the new path operates as expected.

PR validation:

Run successfully the workflow: runTheMatrix.py --what upgrade -l 29634.77 -t 4 -j 8.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed.

Cc: @rovere

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 24, 2025

type ngt

@cmsbuild cmsbuild added the ngt label Feb 24, 2025
@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Feb 24, 2025

test parameters:

  • relval_opts = -w upgrade
  • workflows = 29634.77

@mmusich
Copy link
Contributor Author

mmusich commented Feb 24, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b642df/44613/summary.html
COMMIT: 82f4c19
CMSSW: CMSSW_15_1_X_2025-02-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47434/44613/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 69
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920211
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • HLTrigger/Configuration (hlt)

@AdrianoDee, @Martin-Grunewald, @Moanwar, @cmsbuild, @DickyChant, @miquork, @mmusich, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @fabiocos, @makortel, @missirol, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 4, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2025

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b642df/44794/summary.html
COMMIT: e16fa1b
CMSSW: CMSSW_15_1_X_2025-03-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47434/44794/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b642df/44794/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b642df/44794/git-merge-result

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 64
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920216
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Mar 4, 2025

+hlt

@Moanwar
Copy link
Contributor

Moanwar commented Mar 5, 2025

+Upgrade

@mmusich
Copy link
Contributor Author

mmusich commented Mar 6, 2025

kind ping @cms-sw/pdmv-l2 (I have a follow-up PR that I prefer to keep separate).

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8655d7b into cms-sw:master Mar 6, 2025
12 checks passed
@mmusich mmusich deleted the mm_dev_DST_phase2_from_15_0_0_pre3 branch March 6, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants