HLT menu development for 15_0_X (2/N) [15_1_X]

[mmusich]

PR description:

Development of HLT menus for CMSSW_15_0_X (branch CMSSW_15_1_X):

• This is the PR for the master branch, which will then be backported down to 15_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).
• These updates correspond to the changes accumulated in the 15_0_X release cycle after the "V1.0" GRun menu for the 2025 pp data-taking period was released.

This update includes the integration of the following JIRA tickets:

• CMSHLT-3427 [TSG/FOG] Adding MinBias Paths to "FirstCollisions" menu (Run2025A)
• CMSHLT-3434 [TSG] Move OutputModules from FinalPaths to EndPaths

The latter ticket is in the response of a discussion happened at the Core-S/W meeting on Jan-28, 2025.

• Core-S/W is interested in removing FinalPath (see this cmsTalk).
• TSG has implemented updates to the legacy ConfDB GUI in order to use EndPaths again, rather than FinalPaths, while still supporting existing HLT configs that are using FinalPaths (see for more details going back to using EndPaths instead of FinalPaths in HLT configs hlt-confdb#101 and its solution place OutputModules on EndPaths (not FinalPaths) in HLT configs hlt-confdb#103 ).

side note: some TSG tools in HLTrigger/Configuration still need to remove support for FinalPaths. This will be done at a second time, whence the core support for it will be cut out from the core-S/W group.

PR validation:

TSG Integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_15_0_X.

[cmsbuild]

cms-bot internal usage

[mmusich]

type hlt-integration

[mmusich]

@cms-sw/core-l2 FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47529/43988

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @argiro, @missirol, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[makortel]

Thanks! Just to make it clear, (referring to the discussion in cms-sw/hlt-confdb#103) is it that after this PR you'd want the FinalPath support to be removed from the framework, and after that you will update the TSG tools mentioned in the PR description

side note: some TSG tools in HLTrigger/Configuration still need to remove support for FinalPaths. This will be done at a second time, whence the core support for it will be cut out from the core-S/W group.

?

[mmusich]

is it that after this PR you'd want the FinalPath support to be removed from the framework, and after that you will update the TSG tools mentioned in the PR description

Yes, I think this is a possible way forward (the tools I am talking about are mostly these two:

cmssw/HLTrigger/Configuration/scripts/hltDumpStream

Lines 144 to 147 in b1fb00e

	# find EndPath/FinalPath containing stream OutputModule
	streamPath = None
	outputModule = process.outputModules_()[outModName]
	for efPaths in [process.endpaths_().values(), process.finalpaths_().values()]:

and

cmssw/HLTrigger/Configuration/scripts/hltListPaths

Lines 72 to 76 in b1fb00e

	for pathDict in [
	process.paths_() if usePaths else None,
	process.endpaths_() if useEndPaths else None,
	process.finalpaths_() if useFinalPaths else None,
	]:

I might have missed others, though)

[cmsbuild]

+1

Size: This PR adds an extra 1444KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7b690/44847/summary.html
COMMIT: d6eb08b
CMSSW: CMSSW_15_1_X_2025-03-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47529/44847/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920287
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920261
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.08000000000000002 KiB( 48 files compared)
• DQMHistoSizes: changed ( 145.014,... ): 0.008 KiB HLT/Filters
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

is it that after this PR you'd want the FinalPath support to be removed from the framework, and after that you will update the TSG tools mentioned in the PR description

Yes, I think this is a possible way forward (the tools I am talking about are mostly these two:

cmssw/HLTrigger/Configuration/scripts/hltDumpStream

Lines 144 to 147 in b1fb00e

	# find EndPath/FinalPath containing stream OutputModule
	streamPath = None
	outputModule = process.outputModules_()[outModName]
	for efPaths in [process.endpaths_().values(), process.finalpaths_().values()]:

and

cmssw/HLTrigger/Configuration/scripts/hltListPaths

Lines 72 to 76 in b1fb00e

	for pathDict in [
	process.paths_() if usePaths else None,
	process.endpaths_() if useEndPaths else None,
	process.finalpaths_() if useFinalPaths else None,
	]:

I might have missed others, though)

Thanks, although I'm now a bit confused. Those tools will start to fail after we remove the FinalPath from the framework. Just to make sure, Is that the behavior you want? (i.e. effectively discover what needs to be updated by the tools failing)

[mmusich]

Those tools will start to fail after we remove the FinalPath from the framework. Just to make sure, Is that the behavior you want? (i.e. effectively discover what needs to be updated by the tools failing)

let's say I was hoping you would remove the dependency from your side when you remove support. I can provide a commit in case. I am reluctant to remove them now.

[mandrenguyen]

+1

[makortel]

Those tools will start to fail after we remove the FinalPath from the framework. Just to make sure, Is that the behavior you want? (i.e. effectively discover what needs to be updated by the tools failing)

let's say I was hoping you would remove the dependency from your side when you remove support. I can provide a commit in case. I am reluctant to remove them now.

Thanks for the clarification. We can remove dependencies that we can easily find with git grep, or that come up as part of the PR tests.

[makortel]

Those tools will start to fail after we remove the FinalPath from the framework. Just to make sure, Is that the behavior you want? (i.e. effectively discover what needs to be updated by the tools failing)

let's say I was hoping you would remove the dependency from your side when you remove support. I can provide a commit in case. I am reluctant to remove them now.

Thanks for the clarification. We can remove dependencies that we can easily find with git grep, or that come up as part of the PR tests.

Done in #47546