Remove FinalPath from the framework

[makortel]

PR description:

This PR removes the FinalPath feature from the framework following #47529 that removed the use of it from the HLT menu. HLT requested quick removal of the feature from the framework in cms-sw/hlt-confdb#103. This PR also removes the uses of FinalPath from HLT tools that were easily found with git grep (that was also asked in #47529).

Resolves cms-sw/framework-team#1297

PR validation:

Framework unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not planned to be backported, but theoretically could be backported to 15_0_X if requested.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47546/44018

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/interface/OutputModuleCore.h modified in PR(s): Compartmentalize how ProductRegistry is filled #47533
  • File FWCore/Framework/src/OutputModuleCore.cc modified in PR(s): Compartmentalize how ProductRegistry is filled #47533
  • File FWCore/Framework/src/Schedule.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858, Access PathsAndConsumesOfModules from new signal #47467, Compartmentalize how ProductRegistry is filled #47533
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Implement a GenericCloner test module #47504
  • File FWCore/ParameterSet/python/Config.py modified in PR(s): faster edmConfigDump with --prune, also prunes unreferenced PSets #43276, Introduce vFloat and float types in ParameterSets #45216

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47546/44018/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47546/44018/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mmusich]

thanks @makortel

Not planned to be backported, but theoretically could be backported to 15_0_X if requested.

as all of the 2025 online pp data-taking will be developed in 15_0_X I think it makes sense to backport this @cms-sw/hlt-l2 @missirol please let me know what you think as well.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47546/44019

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/interface/OutputModuleCore.h modified in PR(s): Compartmentalize how ProductRegistry is filled #47533
  • File FWCore/Framework/src/OutputModuleCore.cc modified in PR(s): Compartmentalize how ProductRegistry is filled #47533
  • File FWCore/Framework/src/Schedule.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858, Access PathsAndConsumesOfModules from new signal #47467, Compartmentalize how ProductRegistry is filled #47533
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Implement a GenericCloner test module #47504
  • File FWCore/ParameterSet/python/Config.py modified in PR(s): faster edmConfigDump with --prune, also prunes unreferenced PSets #43276, Introduce vFloat and float types in ParameterSets #45216

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• FWCore/Framework (core)
• FWCore/Integration (core)
• FWCore/ParameterSet (core)
• HLTrigger/Configuration (hlt)

@Dr15Jones, @Martin-Grunewald, @cmsbuild, @makortel, @mmusich, @smuzaffar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[missirol]

as all of the 2025 online pp data-taking will be developed in 15_0_X I think it makes sense to backport this @cms-sw/hlt-l2 @missirol please let me know what you think as well.

I think it makes sense.

[makortel]

as all of the 2025 online pp data-taking will be developed in 15_0_X I think it makes sense to backport this @cms-sw/hlt-l2 @missirol please let me know what you think as well.

I think it makes sense.

Ok. I can prepare a backport (after this PR gets merged).

[cmsbuild]

+1

Size: This PR adds an extra 132KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c8cde/44894/summary.html
COMMIT: 37096f4
CMSSW: CMSSW_15_1_X_2025-03-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47546/44894/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920300
• DQMHistoTests: Total failures: 67
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920213
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #47071

[cmsbuild]

Pull request #47546 was updated. @Dr15Jones, @Martin-Grunewald, @cmsbuild, @makortel, @mmusich, @smuzaffar can you please check and sign again.

[makortel]

@cmsbuild, please test

[makortel]

@smuzaffar @iarspider I'm wondering why the bot removed the core-approved label after I force-pushed an update that changed a file outside of core?

[iarspider]

@makortel investigating.

[iarspider]

Reconstruction:

• At 2025-03-10 15:22:50 (GMT), two commits wer created: e175131 and 37096f4.
• Bot marked e175131 as latest one (based on the order in which github api returns commits).
• Signing comment was assigned to that commit.
• Later, when force-push happened, the order in which we iterate over commits (before sorting them by timestamp) changed, and 37096f4 was considered as happening later than e175131, and thus signing comment was attributed to commit 37096f4.
• This didn't match cached information and signature was ignored:

  WARNING: Comment 2711782634, cached commit e175131 doesn't match the present commit 37096f4. This comment will be ignored.

Why the order has changed:

When processing a PR, the bot first collects all commits (as returned by github, sorted by time descending) into a list, then appends any "missing" (squashed) commits from cache, then sorts that list by timestamp. The timestamps we get from GitHub API have a precision of 1s. Since commit e175131 was squashed, it was added to the end of the list, so from bot's point of view it now happened earlier than 37096f4 .

Fix

To be discussed. We need a better sorting key than (or in addition to) timestamp - e.g. base64-decoded node_id returned by github, or our own internal counter (that must be saved to bot cache)?

[makortel]

Thanks @iarspider. Could you spin your detailed analysis into an issue (cmssw? cms-bot?) so that it (and the following discussion) won't get lost with this PR?

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c8cde/44918/summary.html
COMMIT: dbf601e
CMSSW: CMSSW_15_1_X_2025-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47546/44918/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920300
• DQMHistoTests: Total failures: 58
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920222
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #47071

[makortel]

+core

[mmusich]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1