Skip to content

AlpakaServiceSerialSync should always be available #47672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 24, 2025

PR description:

The AlpakaServiceSerialSync should always be available, even if the "cpu" accelerator is not listed in process.options.accelerators.

PR validation:

The workflows 141.044407 and 141.044483 were failing due to the missing AlpakaServiceSerialSync in step3.
With these changes they run successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 15.0.x for data taking.

The AlpakaServiceSerialSync should always be available, even if the
"cpu" accelerator is not listed in process.options.accelerators.
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2025

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

fixes #43780

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

please test with #47377

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaCore (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fwyzard fwyzard changed the title The AlpakaServiceSerialSync should always be available AlpakaServiceSerialSync should always be available Mar 24, 2025
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faa1f9/45162/summary.html
COMMIT: a710f8b
CMSSW: CMSSW_15_1_X_2025-03-23-2300/el8_amd64_gcc12
Additional Tests: ROCM,CUDA
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47672/45162/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3909207
  • DQMHistoTests: Total failures: 127
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3909060
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

CUDA Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53071
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 53035
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

ROCM Comparison Summary

Summary:

  • You potentially removed 80 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53071
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 53032
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

test parameters:

  • enable_test = gpu
  • workflows_gpu = 141.044407,141.044483

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

141.044407 and 141.044483 fail in the GPU IBs because they don't find the alpaka_serial_sync::AlpakaService for the GPU-only workflows.

These changes should fix that.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-ROCM
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faa1f9/45178/summary.html
COMMIT: a710f8b
CMSSW: CMSSW_15_1_X_2025-03-24-1100/el8_amd64_gcc12
Additional Tests: ROCM,CUDA
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47672/45178/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-ROCM

  • 12834.40612834.406_TTbar_14TeV+2024_Patatrack_PixelOnlyTripletsAlpaka/step3_TTbar_14TeV+2024_Patatrack_PixelOnlyTripletsAlpaka.log

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3909207
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3909185
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

CUDA Comparison Summary

There are some workflows for which there are errors in the baseline:
141.044407 step 3
141.044483 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 177 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53071
  • DQMHistoTests: Total failures: 885
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52186
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 29 log files, 35 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

ignore tests-rejected with ib-failure

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 59e3ded into cms-sw:master Mar 25, 2025
17 of 18 checks passed
@fwyzard fwyzard deleted the always_load_AlpakaServiceSerialSync branch March 25, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants