Skip to content

AlpakaServiceSerialSync should always be available [15.0.x] #47673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 24, 2025

PR description:

The AlpakaServiceSerialSync should always be available, even if the "cpu" accelerator is not listed in process.options.accelerators.

PR validation:

The workflows 141.044407 and 141.044483 were failing due to the missing AlpakaServiceSerialSync in step3.
With these changes they run successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #47672 to 15.0.x for data taking.

The AlpakaServiceSerialSync should always be available, even if the
"cpu" accelerator is not listed in process.options.accelerators.
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

backport #47672

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Mar 24, 2025
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2025

A new Pull Request was created by @fwyzard for CMSSW_15_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaCore (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2025

cms-bot internal usage

@fwyzard fwyzard changed the title The AlpakaServiceSerialSync should always be available [15.0.x] AlpakaServiceSerialSync should always be available [15.0.x] Mar 24, 2025
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea03bc/45163/summary.html
COMMIT: a50a1ba
CMSSW: CMSSW_15_0_X_2025-03-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47673/45163/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3999716
  • DQMHistoTests: Total failures: 66
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3999630
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2025

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit aad02aa into cms-sw:CMSSW_15_0_X Apr 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants