[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.2 #47693

jfernan2 · 2025-03-25T18:51:46Z

PR description:

This PR implements recent changes and upgrades in the L1T DT Trigger Phase-2 emulator, to be in synch with the firmware development and in view of the L1T Annual Review. All changes have been shown and approved in DT Upgrade meetings:

FIrst version of Shower Tagging standalone module, by Daniel Estrada ( @DanielEstrada971102 ). Details in [1]
Removal of coincidence filter filter to let pass all TPs in WH±2 MB1, by Dermot Moran ( @dermotmoran ). Details in [2]
First version of theta-phi matching for DT TPs. Details in [3]

[1] https://indico.cern.ch/event/1516348/contributions/6380929/attachments/3018461/5324512/Triggering%20on%20muon%20showers.pdf

[2] https://indico.cern.ch/event/1531131/contributions/6442596/attachments/3039970/5369581/BMTL1-OMTF%20discussions.pdf

[3] https://indico.cern.ch/event/1478487/contributions/6227895/attachments/2966841/5219995/thetaImplementation_v2.pdf

PR validation:

Local validation within CMSSW and w.r.t. firmware (w.i.p.)

cmsbuild · 2025-03-25T18:52:18Z

cms-bot internal usage

cmsbuild · 2025-03-25T18:53:59Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47693/44241

Found files with invalid states:
- L1Trigger/DTTriggerPhase2/interface/ShowerGrouping.h:
  - Added: b8131cd
  - Deleted: 7e2870c
- L1Trigger/DTTriggerPhase2/src/ShowerBuffer.cc:
  - Added: b8131cd
  - Deleted: 7e2870c
- L1Trigger/DTTriggerPhase2/src/ShowerGrouping.cc:
  - Added: b8131cd
  - Deleted: 7e2870c
- L1Trigger/DTTriggerPhase2/interface/ShowerBuffer.h:
  - Added: b8131cd
  - Deleted: 7e2870c

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47693/44241/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47693/44241/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47693/44241/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47693/44241/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

pluging to emulate DT Muon Shower algorithm - only hits counting by chamber

change pluging to manage emulation of DT Muon Shower firmware algorithm v 0.2.0

It was added to: - L1Trigger/DTTriggerPhase2/test codes. - L1Trigger/Configuration. - L1Trigger/Phase2L1GMT/test codes.

cmsbuild · 2025-03-26T11:44:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47693/44248

Found files with invalid states:
- L1Trigger/DTTriggerPhase2/interface/ShowerGrouping.h:
  - Added: e502372
  - Deleted: 55ff2d3
- L1Trigger/DTTriggerPhase2/src/ShowerBuffer.cc:
  - Added: e502372
  - Deleted: 55ff2d3
- L1Trigger/DTTriggerPhase2/src/ShowerGrouping.cc:
  - Added: e502372
  - Deleted: 55ff2d3
- L1Trigger/DTTriggerPhase2/interface/ShowerBuffer.h:
  - Added: e502372
  - Deleted: 55ff2d3

cmsbuild · 2025-03-26T11:44:54Z

Pull request #47693 was updated.

cmsbuild · 2025-04-11T15:23:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47693/44489

Found files with invalid states:
- L1Trigger/DTTriggerPhase2/interface/ShowerGrouping.h:
  - Added: e502372
  - Deleted: 55ff2d3
- L1Trigger/DTTriggerPhase2/src/ShowerBuffer.cc:
  - Added: e502372
  - Deleted: 55ff2d3
- L1Trigger/DTTriggerPhase2/src/ShowerGrouping.cc:
  - Added: e502372
  - Deleted: 55ff2d3
- L1Trigger/DTTriggerPhase2/interface/ShowerBuffer.h:
  - Added: e502372
  - Deleted: 55ff2d3
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): [L1T] PR containing simulation and emulation related to jet mass reconstruction (Phase-2) #47792, [L1T] L1TSC4NGJetModel (Phase 2) #47798

cmsbuild · 2025-04-11T15:23:44Z

Pull request #47693 was updated. @BenjaminRS, @Moanwar, @cmsbuild, @quinnanm, @srimanob, @subirsarkar can you please check and sign again.

BenjaminRS · 2025-04-11T15:27:18Z

please test

cmsbuild · 2025-04-11T17:29:32Z

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d55700/45517/summary.html
COMMIT: b36e41a
CMSSW: CMSSW_15_1_X_2025-04-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47693/45517/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 4027853
DQMHistoTests: Total failures: 76
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4027757
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 220 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

BenjaminRS · 2025-04-11T18:20:47Z

+l1

Moanwar · 2025-04-14T19:14:36Z

+Upgrade

cmsbuild · 2025-04-14T19:15:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-04-15T11:23:21Z

+1

cmsbuild added this to the CMSSW_15_1_X milestone Mar 25, 2025

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending changes-dataformats labels Mar 25, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 25, 2025

jfernan2 and others added 11 commits March 26, 2025 12:31

First version of Theta-Phi matching

57ac712

Debugged version with Theta selection q=3

3491457

First working version of filter, with couts

974b39f

Version with comments, ExtWheels exception and t0phi

58df6f8

Exception on WhMB1 by Dermot Moran

bb8b623

Exception 2 TPs Wh2 MB1/2, BestThetaWh0, t0phi

c507605

Changes from D. Morat to coincidence exception on external chambers

b0ca810

Create DTTrigPh2ShowerProducer

e502372

pluging to emulate DT Muon Shower algorithm - only hits counting by chamber

Refactor DTTrigPh2ShowerProducer

55ff2d3

change pluging to manage emulation of DT Muon Shower firmware algorithm v 0.2.0

Incude DTTrigerPh2Shower_cfi

2a8f734

It was added to: - L1Trigger/DTTriggerPhase2/test codes. - L1Trigger/Configuration. - L1Trigger/Phase2L1GMT/test codes.

Code format

edc73aa

jfernan2 force-pushed the AMv2.2 branch from 6457d81 to edc73aa Compare March 26, 2025 11:42

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 26, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 26, 2025

Code format

b36e41a

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-rejected labels Apr 11, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 11, 2025

cmsbuild added tests-started and removed tests-pending labels Apr 11, 2025

cmsbuild added tests-approved and removed tests-started labels Apr 11, 2025

cmsbuild added l1-approved and removed l1-pending labels Apr 11, 2025

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Apr 14, 2025

cmsbuild added orp-approved and removed orp-pending labels Apr 15, 2025

cmsbuild merged commit 5c0ff13 into cms-sw:master Apr 15, 2025
12 checks passed

This was referenced Apr 16, 2025

CALO-L2 EG, Tau, Jet calibrations with conservative ZS for first L1 menu 2025 #47730

Merged

[ROOT6} Do not merge, testing aarch64 cms-sw/cmsdist#9789

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.2 #47693

[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.2 #47693

jfernan2 commented Mar 25, 2025 •

edited

Loading

cmsbuild commented Mar 25, 2025 •

edited

Loading

cmsbuild commented Mar 25, 2025

cmsbuild commented Mar 26, 2025

cmsbuild commented Mar 26, 2025

cmsbuild commented Apr 11, 2025

cmsbuild commented Apr 11, 2025

BenjaminRS commented Apr 11, 2025

cmsbuild commented Apr 11, 2025

BenjaminRS commented Apr 11, 2025

Moanwar commented Apr 14, 2025

cmsbuild commented Apr 14, 2025

mandrenguyen commented Apr 15, 2025

[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.2 #47693

[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.2 #47693

Conversation

jfernan2 commented Mar 25, 2025 • edited Loading

PR description:

PR validation:

cmsbuild commented Mar 25, 2025 • edited Loading

cmsbuild commented Mar 25, 2025

cmsbuild commented Mar 26, 2025

cmsbuild commented Mar 26, 2025

cmsbuild commented Apr 11, 2025

cmsbuild commented Apr 11, 2025

BenjaminRS commented Apr 11, 2025

cmsbuild commented Apr 11, 2025

Comparison Summary

BenjaminRS commented Apr 11, 2025

Moanwar commented Apr 14, 2025

cmsbuild commented Apr 14, 2025

mandrenguyen commented Apr 15, 2025

jfernan2 commented Mar 25, 2025 •

edited

Loading

cmsbuild commented Mar 25, 2025 •

edited

Loading