Skip to content

[15_0_X] Backport of #47739 (Add filter to skip events without scouting objects in ScoutingNano for ScoutingPFMonitor dataset) #47800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

patinkaew
Copy link
Contributor

PR description:

Backport of cms-sw/cmssw#47739 to 15_0_X for 2025 data-taking.

PR validation:

Similar validations to cms-sw/cmssw#47739 were run.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to 15_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2025

A new Pull Request was created by @patinkaew for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • PhysicsTools/NanoAOD (xpog)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @ftorrresd, @hqucms, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2025

cms-bot internal usage

@patinkaew
Copy link
Contributor Author

Tagging scouting conveners @silviodonato @elfontan.

@vlimant
Copy link
Contributor

vlimant commented Apr 7, 2025

enable nano

@vlimant
Copy link
Contributor

vlimant commented Apr 7, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bd63f/45426/summary.html
COMMIT: c5b140f
CMSSW: CMSSW_15_0_X_2025-04-07-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47800/45426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3999716
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3999670
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.115 3.115 0.000 ( +0.0% ) 6.95 6.84 +1.5% 2.486 2.587
2500.002 3.231 3.231 0.000 ( +0.0% ) 6.14 6.08 +1.0% 2.900 3.018
2500.003 3.172 3.172 0.000 ( +0.0% ) 6.42 6.30 +2.0% 2.887 2.992
2500.011 1.647 1.647 0.000 ( +0.0% ) 11.82 11.45 +3.2% 2.591 2.655
2500.012 2.185 2.185 0.000 ( +0.0% ) 6.57 6.37 +3.1% 2.744 2.839
2500.013 2.002 2.002 0.000 ( +0.0% ) 9.29 8.95 +3.8% 2.659 2.763
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.92 1.89 +1.5% 2.487 2.709
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.84 1.83 +0.1% 2.487 2.706
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.77 1.75 +1.5% 2.441 2.568
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.48 1.48 -0.5% 2.603 2.808
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.66 1.66 +0.2% 2.582 2.771
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.65 1.65 -0.1% 2.570 2.723
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.61 1.61 -0.3% 2.635 2.807
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.61 1.60 +0.8% 2.610 2.782
2500.101 2.872 2.872 0.000 ( +0.0% ) 16.16 15.62 +3.4% 2.510 2.642
2500.111 1.474 1.474 0.000 ( +0.0% ) 31.84 31.05 +2.5% 2.227 2.331
2500.112 1.896 1.896 0.000 ( +0.0% ) 25.14 25.71 -2.2% 2.198 2.418
2500.131 0.750 0.750 0.000 ( +0.0% ) 37.83 35.88 +5.4% 1.357 1.514
2500.201 2.706 2.706 0.000 ( +0.0% ) 13.36 12.81 +4.3% 2.077 2.222
2500.211 1.845 1.845 0.000 ( +0.0% ) 26.99 25.76 +4.8% 2.191 2.416
2500.212 2.243 2.243 0.000 ( +0.0% ) 22.34 23.10 -3.3% 2.226 2.505
2500.221 2.141 2.141 0.000 ( +0.0% ) 14.04 13.89 +1.1% 1.922 2.135
2500.222 3.516 3.516 0.000 ( +0.0% ) 13.10 13.27 -1.3% 1.983 2.227
2500.223 10.328 10.328 0.000 ( +0.0% ) 4.64 4.55 +2.1% 2.132 2.396
2500.224 6.622 6.622 0.000 ( +0.0% ) 1.26 1.23 +1.9% 2.106 2.357
2500.225 6.671 6.671 0.000 ( +0.0% ) 1.18 1.15 +2.3% 2.301 2.557
2500.226 3.210 3.210 0.000 ( +0.0% ) 13.55 12.73 +6.4% 1.985 2.217
2500.227 1.442 1.442 0.000 ( +0.0% ) 24.14 23.10 +4.5% 1.308 1.452
2500.228 4.045 4.045 0.000 ( +0.0% ) 8.99 8.78 +2.5% 2.238 2.332
2500.231 1.516 1.516 0.000 ( +0.0% ) 22.13 20.64 +7.2% 2.101 2.322
2500.232 2.502 2.502 0.000 ( +0.0% ) 21.55 20.63 +4.4% 2.121 2.411
2500.233 5.422 5.422 0.000 ( +0.0% ) 7.02 6.95 +1.0% 2.271 2.573
2500.234 3.928 3.928 0.000 ( +0.0% ) 1.61 1.59 +1.6% 2.223 2.488
2500.235 3.960 3.960 0.000 ( +0.0% ) 1.52 1.51 +1.0% 2.421 2.696
2500.236 2.292 2.292 0.000 ( +0.0% ) 22.84 22.29 +2.4% 2.146 2.401
2500.237 1.018 1.018 0.000 ( +0.0% ) 35.61 34.63 +2.8% 1.430 1.465
2500.238 2.477 2.477 0.000 ( +0.0% ) 17.42 16.84 +3.4% 2.322 2.477
2500.241 9.404 9.404 0.000 ( +0.0% ) 7.60 7.80 -2.6% 1.786 1.937
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.69 1.68 +0.7% 1.630 1.735
2500.243 2.712 2.712 0.000 ( +0.0% ) 16.02 15.01 +6.7% 1.016 1.067
2500.244 486.016 486.016 0.000 ( +0.0% ) 1.16 1.14 +1.7% 1.556 1.695
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.54 1.52 +1.3% 1.563 1.698
2500.251 645.333 645.333 0.000 ( +0.0% ) 1.68 1.65 +1.6% 1.717 1.790
2500.301 0.021 0.021 0.000 ( +0.0% ) 1.78 1.77 +0.7% 2.635 2.839
2500.311 0.036 0.036 0.000 ( +0.0% ) 1.72 1.69 +1.7% 2.638 2.781
2500.901 1.819 1.819 0.000 ( +0.0% ) 45.68 46.07 -0.8% 1.445 1.446
2500.902 1.665 1.665 0.000 ( +0.0% ) 48.70 47.25 +3.1% 1.335 1.348
2500.911 14.345 14.345 0.000 ( +0.0% ) 8.24 7.28 +13.3% 1.058 1.101
2500.912 0.171 0.150 0.021 ( +14.1% ) 3.47 3.29 +5.4% 0.857 0.853
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.62 2.65 -0.9% 0.831 0.861

@ftorrresd
Copy link
Contributor

+1

@Moanwar
Copy link
Contributor

Moanwar commented Apr 8, 2025

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants