Add filter to skip events without scouting objects in ScoutingNano for ScoutingPFMonitor dataset #47739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47739/44312
|
|
A new Pull Request was created by @patinkaew for master. It involves the following packages:
@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @ftorrresd, @hqucms, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable nano |
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
@cms-sw/xpog-l2 @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 do you have any comments? |
|
+Upgrade |
|
+1 |
|
is there a 15.0 backport already pending for this ? |
|
+pdmv |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pending-signatures
pdmv-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
Hi @vlimant
I just opened a backport PR cms-sw/cmssw#7800. Sorry for a delay. |
|
no pb. thanks. |
cmsbuild
added a commit
that referenced
this pull request
Apr 23, 2025
[15_0_X] Backport of #47739 (Add filter to skip events without scouting objects in ScoutingNano for ScoutingPFMonitor dataset)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR supersedes cms-sw/cmssw#47302 on filter implementation (Another part on era modifier implemented in cms-sw/cmssw#47302 will be superseded by another PR).
In 2022-24, ScoutingPFMonitor dataset consists of logical-OR of scouting and standard HLT paths. However, only scouting objects are reconstructed on scouting paths. Events passing only standard HLT paths, but not scouting paths, will not contain scouting products. This gives a proper treatment to the issue with EDFilter instead of previous solution introduced in cms-sw/cmssw#46516.
This is not an issue in 2025 following CMSHLT-3089.
For more technical details,
cmsDriver.pyby adding--customise PhysicsTools/NanoAOD/custom_run3scouting_cff.skipEventsWithoutScouting.@ScoutMonitorflavour similar to@Scoutwith the above customisation added.PR validation:
Pass all tests from
scram b runtests use-ibeos.Pass all ScoutingNano-related relval_nano workflows from
In addition, several
cmsDriver.pycommands have been tested on data and MC samples documented in [1].In brief, concerning data:
@Scoutworks for ScoutingPFRun3 2022-24@ScoutMonitorworks for ScoutingPFMonitor 2022-24@ScoutFromMiniworks for ScoutingPFMonitor 2024 (Scouting objects are in MiniAOD starting in Prompt 2024)@Prompt+@ScoutMonitorworks for ScoutingPFMonitor 2023. Input 2022 fails because of Tau.@Prompt+@ScoutFromMiniworks for ScoutingPFMonitor 2024 (Scouting objects are in MiniAOD starting in Prompt 2024)Please see commands in [1]. Relevant test results (python config, root, event content, size report, log) are included in [2]. Summary of size report is in [3].
Moreover, since this might be used for prompt reconstruction, to simulate the prompt reconstruction workflow, we ran
RunPromptReco.py(with modifiedn=1000) with the following command:This step reconstructs
fileIn.rootin RAW tier to RECO, AOD, MINIAOD, NANOAOD, and DQMIO. The output files in RECO, AOD, and MINIAOD have 1000 events while NANOAOD (in NANOAODEDM) has 986 events. This is expected since the filter is applied for NANOAOD.Finally, merge step is run with
The output file is now in final NANOAOD format (TTree with all primitives) and has 986 events. The event content contains standard, L1, and scouting objects as expected (
@PHYS+@L1+@ScoutMonitor).If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is not a backport.
[1] https://codimd.web.cern.ch/PTeusxQURcmBaS7Ilfv9GQ?view
[2] https://cernbox.cern.ch/s/J64vQTyn6J5FgRC
[3] https://docs.google.com/spreadsheets/d/10UFlWqurxMTuXy0HeulFTjbx5lUca9ZeM4CAXkC12Wo/edit?usp=sharing