Skip to content

Fix siPixelDigiMorphing modifer and create workflows to test it #47872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 15, 2025

PR description:

Title says it all.

PR validation:

Run runTheMatrix.py -l 16834.18

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47872/44519

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @jfernan2, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dkotlins, @fabiocos, @felicepantaleo, @ferencek, @gpetruc, @makortel, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @slomeo, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 16, 2025

test parameters:

  • relvals_opt = --what upgrade
  • workflows = 16834.18

@mmusich
Copy link
Contributor Author

mmusich commented Apr 16, 2025

waiting for #47881 to be resolved before launching tests.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47872/44521

@cmsbuild
Copy link
Contributor

Pull request #47872 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @jfernan2, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@smuzaffar
Copy link
Contributor

please test

@mmusich , #47881 has been fixed now

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7754e8/45574/summary.html
COMMIT: 520f256
CMSSW: CMSSW_15_1_X_2025-04-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47872/45574/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3916361
  • DQMHistoTests: Total failures: 75
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3916266
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@Moanwar
Copy link
Contributor

Moanwar commented Apr 16, 2025

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Apr 16, 2025

type bugfix

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 80acb0f into cms-sw:master Apr 16, 2025
12 checks passed
@mmusich mmusich deleted the mm_dev_PixelDigiMorphing_wfs branch April 17, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants