-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Avoid adding .root to a file ending in .rntpl in ConfigBuilder #47888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid adding .root to a file ending in .rntpl in ConfigBuilder #47888
Conversation
This was uncovered in the RNTUPLE IBs.
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47888/44529
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@antoniovilela, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 44KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
@cms-sw/operations-l2 ping |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This was uncovered in the RNTUPLE IBs.
PR validation:
Using this change in the RNTUPLE release allows workflow 138.3 to get the correct file name for step2.
resolves cms-sw/framework-team#1352