Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 17, 2025

PR description:

Due to the issues explained in #49349, in preparation of a partial revert of the HLT menu change at CMSHLT-3147 via the ticket CMSHLT-3691, I open this PR that partially reverts #49340 and #49237 by:

PR validation:

Tested successfully:

  • scram b runtests_TestDQMOnlineClient-pixelgpu_dqm_sourceclient
  • runTheMatrix.py --what gpu -l 17034.402 -t 4 -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might get backported to CMSSW_15_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49397/46846

@mmusich
Copy link
Contributor Author

mmusich commented Nov 17, 2025

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Nov 17, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49397/46847

@cmsbuild
Copy link
Contributor

Pull request #49397 was updated.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 17, 2025

@cmsbuild, please test

@mmusich mmusich force-pushed the mm_make_pixel_gpu_on_demand branch from 0f0c9e7 to 766d2b0 Compare November 17, 2025 16:31
@mmusich mmusich force-pushed the mm_make_pixel_gpu_on_demand branch from 766d2b0 to a4ac4d6 Compare November 17, 2025 16:32
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49397/46849

@cmsbuild
Copy link
Contributor

Pull request #49397 was updated.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 17, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0dcc76/49503/summary.html
COMMIT: a4ac4d6
CMSSW: CMSSW_16_0_X_2025-11-17-1200/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49397/49503/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

AMD_MI300X Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 223 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 26713
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 121468
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -51889.422 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 17034.402,... ): -8648.237 KiB HLT/HeterogeneousComparisons
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 2 / 10 workflows

AMD_W7900 Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 253 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 26952
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 121227
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -51889.422 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 17034.402,... ): -8648.237 KiB HLT/HeterogeneousComparisons
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 234 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 26591
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 121594
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -51889.422 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 17034.402,... ): -8648.237 KiB HLT/HeterogeneousComparisons
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 224 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 33695
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 114487
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -51889.422 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 17034.402,... ): -8648.237 KiB HLT/HeterogeneousComparisons
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_T4 Comparison Summary

Summary:

  • You potentially removed 17 lines from the logs
  • Reco comparison results: 222 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 33933
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 114247
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -51889.422 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 17034.402,... ): -8648.237 KiB HLT/HeterogeneousComparisons
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 2 / 10 workflows

@mmusich mmusich marked this pull request as ready for review November 19, 2025 14:04
@mmusich
Copy link
Contributor Author

mmusich commented Nov 19, 2025

Opening this for review given that CMSHLT-3691 converged.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/SiPixelHeterogeneous (dqm)
  • DQMOffline/Trigger (dqm)

@ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @batinkov, @cericeci, @fioriNTU, @francescobrivio, @idebruyn, @jandrea, @jhgoh, @missirol, @mtosi, @rociovilar, @threus, @trocino this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@nothingface0
Copy link
Contributor

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 87fa6bd into cms-sw:master Nov 21, 2025
25 checks passed
@mmusich mmusich deleted the mm_make_pixel_gpu_on_demand branch November 21, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants