Skip to content

[16_0_X] HcalDQM: Add calibration monitoring to offline sequence #50596

Open
lwang046 wants to merge 3 commits intocms-sw:CMSSW_16_0_Xfrom
lwang046:HcalDQM-offlineCUMon
Open

[16_0_X] HcalDQM: Add calibration monitoring to offline sequence #50596
lwang046 wants to merge 3 commits intocms-sw:CMSSW_16_0_Xfrom
lwang046:HcalDQM-offlineCUMon

Conversation

@lwang046
Copy link
Copy Markdown
Contributor

@lwang046 lwang046 commented Mar 31, 2026

PR description:

In PR #48510 and PR #48679 we added monitoring of hcal calibration units for online sequence, this PR will sync the same monitoring to the offline hcal dqm sequence, adding FED based summary plots for DigiRunSummary folder.

PR validation:

Developed and tested on top of CMSSW_16_0_4_patch1. A recent run 402560 is processed with offline code with plots shown in local hcal DQM gui, and compare it with the central online GUI, all looks in consistency, except for the NchsHF in FED 1118 and 1120, that is another issue currently under investigation by Hcal group

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 31, 2026

A new Pull Request was created by @lwang046 for CMSSW_16_0_X.

It involves the following packages:

  • DQM/HcalCommon (dqm)
  • DQM/HcalTasks (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda, @denizsun, @salimcerci this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 31, 2026

cms-bot internal usage

@gabrielmscampos
Copy link
Copy Markdown
Member

please test

@gabrielmscampos
Copy link
Copy Markdown
Member

backport of #50598

@gabrielmscampos
Copy link
Copy Markdown
Member

@lwang046 Please, add [16_0_X] to the title.

@lwang046 lwang046 changed the title HcalDQM: Add calibration monitoring to offline sequence HcalDQM: Add calibration monitoring to offline sequence [16_0_X] Apr 1, 2026
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 1, 2026

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51f2fc/52394/summary.html
COMMIT: 41c2a4b
CMSSW: CMSSW_16_0_X_2026-04-01-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50596/52394/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

  • 7.3A fatal system signal has occurred: segmentation violation
  • 250202.181A fatal system signal has occurred: segmentation violation

@lwang046 lwang046 changed the title HcalDQM: Add calibration monitoring to offline sequence [16_0_X] [16_0_X] HcalDQM: Add calibration monitoring to offline sequence Apr 1, 2026
… and update summary plots with per-FED misfire monitoring granularity
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 2, 2026

Pull request #50596 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

@lwang046
Copy link
Copy Markdown
Contributor Author

lwang046 commented Apr 2, 2026

-1

Failed Tests: RelVals Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51f2fc/52394/summary.html COMMIT: 41c2a4b CMSSW: CMSSW_16_0_X_2026-04-01-1100/el8_amd64_gcc13 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50596/52394/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

  • 7.3A fatal system signal has occurred: segmentation violation
  • 250202.181A fatal system signal has occurred: segmentation violation

The two failures with segfault are caused by an invalid FED 0 entry in _vhashFEDs. There is no FED0 histogram booked in cSummaryvsLS_FED, so Container2D dereferences a null ME pointer and crashes. FED0 should not enter _vhashFEDs.

@gabrielmscampos
Copy link
Copy Markdown
Member

test parameters:

  • addpkg = DQM/Integration

@gabrielmscampos
Copy link
Copy Markdown
Member

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 2, 2026

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51f2fc/52424/summary.html
COMMIT: 56e98f4
CMSSW: CMSSW_16_0_X_2026-04-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50596/52424/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4170687
  • DQMHistoTests: Total failures: 171
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4170496
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 91651.28199999999 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 1757.079 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 1000.0 ): 52.798 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 10224.0 ): 2385.405 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 10224.0 ): 4.784 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 11634.0,... ): 2448.253 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 11634.0,... ): 4.950 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 1306.0,... ): 3.235 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.56 ): 12.239 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2022.0030001,... ): 2322.793 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 2022.0030001 ): 4.752 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2023.0020001 ): ...
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants