Skip to content

HcalDQM: Add calibration monitoring to offline sequence, forward port of PR#50596#50598

Open
lwang046 wants to merge 2 commits intocms-sw:masterfrom
lwang046:HcalDQM-offlineCUMon_fwd
Open

HcalDQM: Add calibration monitoring to offline sequence, forward port of PR#50596#50598
lwang046 wants to merge 2 commits intocms-sw:masterfrom
lwang046:HcalDQM-offlineCUMon_fwd

Conversation

@lwang046
Copy link
Copy Markdown
Contributor

@lwang046 lwang046 commented Mar 31, 2026

PR description:

Add calibration monitoring to offline sequence, forward port of #50596

PR validation:

tested working as expected on HCAL local DQM GUI.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 31, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @lwang046 for master.

It involves the following packages:

  • DQM/HcalCommon (dqm)
  • DQM/HcalTasks (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda, @denizsun, @salimcerci this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@gabrielmscampos
Copy link
Copy Markdown
Member

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 1, 2026

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-534dd5/52395/summary.html
COMMIT: e08e44b
CMSSW: CMSSW_16_1_X_2026-03-31-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50598/52395/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

  • 7.3A fatal system signal has occurred: segmentation violation
  • 250202.181A fatal system signal has occurred: segmentation violation

… and update summary plots with per-FED misfire monitoring granularity
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 2, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50598/48829

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 2, 2026

Pull request #50598 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

@gabrielmscampos
Copy link
Copy Markdown
Member

test parameters:

  • addpkg = DQM/Integration

@gabrielmscampos
Copy link
Copy Markdown
Member

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 2, 2026

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-534dd5/52425/summary.html
COMMIT: 7ef77d6
CMSSW: CMSSW_16_1_X_2026-04-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50598/52425/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4179061
  • DQMHistoTests: Total failures: 50
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4178991
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 92030.206 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 1757.079 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 1000.0 ): 52.798 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 10224.0 ): 2385.405 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 10224.0 ): 4.784 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 11634.0,... ): 2448.253 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 11634.0,... ): 4.950 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 1306.0,... ): 3.235 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.56 ): 12.239 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2022.0010001,... ): 2322.793 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 2022.0010001 ): 32.689 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2023.0020001 ): ...
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants