Skip to content

[HCAL-DQM] Add LS-normalized HCAL LED and pedestal trend plots; set CapID_BadvsLS binning to 1 LS#50623

Open
denizsun wants to merge 5 commits intocms-sw:masterfrom
denizsun:hcal-dqm-led-pedestal-ls-trends
Open

[HCAL-DQM] Add LS-normalized HCAL LED and pedestal trend plots; set CapID_BadvsLS binning to 1 LS#50623
denizsun wants to merge 5 commits intocms-sw:masterfrom
denizsun:hcal-dqm-led-pedestal-ls-trends

Conversation

@denizsun
Copy link
Copy Markdown
Contributor

@denizsun denizsun commented Apr 1, 2026

PR description:

This PR adds LS-based normalized trend plots for HCAL DQM.

In LEDTask:

  • adds LS2-referenced charge and CWT normalized monitoring
  • fills ChargeNormvsLS and CWTNormvsLS using LS-averaged values per channel
  • uses 1 TS pedestal estimate
  • sets CWTNormvsLS to 1 ns/bin in the range [-50, 50] ns

In PedestalTask:

  • adds charge-based LS trend monitoring normalized to LS1
  • computes the per-channel LS average charge and fills ChargeNormvsLS

In DigiTask:

  • set CapID_BadvsLS binning to 1 LS

PR validation:

runTheMatrix test is done

Backport :

This is not a backport PR.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 1, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 1, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50623/48822

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 1, 2026

A new Pull Request was created by @denizsun for master.

It involves the following packages:

  • DQM/HcalTasks (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda, @salimcerci this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@gabrielmscampos
Copy link
Copy Markdown
Member

test parameters:

  • addpkg = DQM/Integration

@gabrielmscampos
Copy link
Copy Markdown
Member

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 2, 2026

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a84091/52423/summary.html
COMMIT: ab7f9b8
CMSSW: CMSSW_16_1_X_2026-04-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50623/52423/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4180749
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 18
  • DQMHistoTests: Total successes: 4180699
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 23540.622999999992 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 478.125 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 10224.0,... ): 618.750 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 11634.0,... ): 632.812 KiB Hcal/DigiTask
  • DQMHistoSizes: changed ( 2022.0010001,... ): 604.688 KiB Hcal/DigiTask
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants