Various fixes for issues flagged by the 'ruff check' linter. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaharkes
commented
Feb 28, 2025
os/kernel/DataStore.py
Outdated
| @@ -31,7 +30,7 @@ def clear_compute_result(self, compute_id): | |||
| self._result_cache.pop(compute_id, None) | |||
|
|
|||
| ######################################################## COMPUTE ############################################################ | |||
| def get_compute_result(self, compute_id, result_type: str) -> Optional[Union[None, tuple]]: | |||
| def get_compute_result(self, compute_id, result_type: str) -> None | tuple | None: | |||
There was a problem hiding this comment.
This weird type annotation is fixed by a later commit.
Bugfix: Invalid deref when no current TM
…back to the hub and process the Telemetry message in the data service.
… with a one-liner.
This prevents retaining telemetry data for each drone indefinitely.
…uce the maximum trail length to improve performance in rednering the map.
- fix f-strings with no placeholders - remove unused imports - move module imports to top of the file
Probably should be fixed at some point, but this allows for a clean run.
ruff check --select E722 # do not use bare except
ruff check --select E741 # ambiguous variable name
ruff check --select F841 # unused local variable
|
rebased against dev, I will drop this and create a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes are all over the place and who knows how much got broken as a result.
I read through the diff a few times now and it mostly looks reasonable, but I guess people should at least look it over.
Alternatively, it may be useful to cherry pick some of the specific commits that actually fix obvious errors and leave some of the reordering of imports to the formatter.
Once a ruff format is done and merged, it is probably fine to re-enable E501 (long lines) and E701 (multiple statements on one line) because most of those should get fixed by reformatting.
Over time more checks can be enabled, like CPY (if all files have the copyright blurbs) and PTH (use Path instead of os.path), enabling all checks (after formatting) flags 4388 issues, but that includes a lot of nice to have but not critical things like missing docstrings and type annotations.