fix(ci): unblock deploy-blueprints synth jobs#188
Merged
Conversation
Three of the five scenario synth jobs were failing on the main-branch deploy-blueprints workflow, and had been since 2026-04-16. - synth-localgov-drupal: TypeScript 6.0 (via a dependabot bump of the typescript devDep) no longer auto-resolves @types/jest for global describe/test/expect without an explicit compilerOptions.types entry. Reproduced locally after a clean npm ci. Added types: ["jest", "node"] to localgov-drupal/cdk/tsconfig.json. Local `tsc --noEmit` now passes. - synth-localgov-ims + synth-minute: both jobs used setup-node with cache: 'npm' and a cache-dependency-path pointing at package-lock.json, but those lock files aren't tracked (root .gitignore ignores package-lock.json). setup-node failed at "Some specified paths were not resolved", skipping all downstream steps. `npm ci` in the next step would have failed for the same reason. Aligned both jobs with the synth-simply-readable pattern: no npm cache, and `npm install` instead of `npm ci`. Slightly slower cold runs; deterministic enough for CI synth+validate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
deploy-blueprintsworkflow on main has been failing since 2026-04-16. Three of five scenario synth jobs broken:synth-localgov-drupal,synth-localgov-ims,synth-minute. Same run referenced: https://github.com/co-cddo/ndx_try_aws_scenarios/actions/runs/24718982438.Root causes
localgov-drupal (tsc error):
typescript: ~6.0.2landed.@types/jestglobals (describe,test,expect) without an explicitcompilerOptions.typesentry.npm ci && tsc --noEmitreproduces the error; adding"types": ["jest", "node"]fixes it.localgov-ims + minute (setup-node fail):
cache: 'npm'withcache-dependency-path: …/package-lock.json..gitignoreglobally ignorespackage-lock.json, so those lock files were never tracked.setup-nodefails with "Some specified paths were not resolved" and skips every downstream step.npm ciwould also have failed for the same missing-lockfile reason.synth-simply-readable(which works): no npm cache,npm installinstead ofnpm ci.Changes
cloudformation/scenarios/localgov-drupal/cdk/tsconfig.json: add"types": ["jest", "node"].github/workflows/deploy-blueprints.yml: remove npm cache lines and switchnpm citonpm installforsynth-localgov-imsandsynth-minuteTest plan
typescript@6.0.2:tsc --noEmitpasses (exit 0).