chore(deps): update node docker tag to v26#321
Closed
chrisns wants to merge 2 commits into
Closed
Conversation
150d6a5 to
b1ce5f7
Compare
…ilures
PR 321 retry uncovered two more issues:
1. delete-file-system fails with ConflictException ("has mount targets")
on file systems that still have mount targets attached. Add a
list-mount-targets + delete-mount-target loop before delete-file-system,
plus a 30s grace for the async deletes to complete.
2. delete_bucket_completely returns 1 when all attempts fail (it opens a
stranded-stack issue and gives up). The bare function call inside the
bucket sweep loop is NOT a conditional context, so set -e fires and
kills the whole pre-deploy script. Adding `|| true` to both the
bucket-sweep and orphan-stack-sweep loops keeps them tolerant of
per-item failures; the stranded-stack issues remain the audit trail.
Also captured stderr explicitly (var + echo) for the file-system delete,
matching the pattern used elsewhere — avoids the `cmd | sed` pipefail
trap that killed earlier iterations.
2 tasks
3 tasks
chrisns
added a commit
that referenced
this pull request
May 20, 2026
When iterative pre-deploy cleanup has accumulated more debris than the
script can sweep in 90 minutes, manual recovery is needed. Add a
workflow-dispatch workflow + script that runs under the existing
smoke-test-deploy role and clears every:
- ${STACK}* CloudFormation stack (top-level)
- AWS::S3Files::FileSystem (with access points + mount targets first)
- NDXTry_* AppRegistry applications
- ndx-try-* Connect instances
- ndx-try-*${ACCOUNT_ID}* S3 buckets
Same identity, same concurrency group as smoke.yml, so the two can't
run simultaneously. Requires typing NUKE as the confirm input to fire,
to avoid accidental destruction of the smoke account.
This is the script side of "manual cleanup" we kept reaching for during
PR #321's CI iterations. After running this, the next smoke run starts
from a true clean slate.
Member
Author
|
Superseded by new renovate grouping (per-scenario + npm-web + github-actions). See #357 for the config change. This PR's dep, if still pending, will be re-opened inside the appropriate grouped PR on the next renovate cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
24.14-alpine→26.1-alpine24.14-alpine→26.1-alpine23-alpine→26-alpineRelease Notes
nodejs/node (node)
v26Moved to doc/changelogs/CHANGELOG_V6.md#6.0.0.
v25Moved to doc/changelogs/CHANGELOG_V012.md#0.12.8.
v24Moved to doc/changelogs/CHANGELOG_IOJS.md#2.1.0.
Configuration
📅 Schedule: (in timezone Europe/London)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate.