Support for string and numbers in isValidNumber function #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alacret
requested changes
Jul 14, 2020
There was a problem hiding this comment.
@jesusrodrz @GerardoAGL96 me parece que isValidString debe forzar a recibir un numero, y quizas un rango seria util tambien.
Me parece que el proceso de convertir un dato de un tipo a otro (normalizacion) debe ser manejado aparte. En todo caso, si queremos tener algo asi como utilitario, podemos hacerlo de una manera mas especifica:
isStringAValidNumberque reciba un string, y por debajo use isValidNumber o algo asi.
Ref: https://gomakethings.com/converting-strings-to-numbers-with-vanilla-javascript/
|
@alacret I added the |
alacret
requested changes
Jul 16, 2020
| * @param {boolean} [allowZero=false] - If the string should accept 0 as a valid number. | ||
| * @param {boolean} [allowNegative=false] - If the string should negative values. | ||
| * | ||
| * @returns {boolean} If the string is valid number or not. | ||
| */ | ||
| export const isValidNumber = (stringToTest: string, allowZero: boolean = false, allowNegative: boolean = false): boolean => { | ||
| export const isValidNumber = (value: string, allowZero: boolean = false, allowNegative: boolean = false): boolean => { |
There was a problem hiding this comment.
Suggested change
| export const isValidNumber = (value: string, allowZero: boolean = false, allowNegative: boolean = false): boolean => { | |
| export const isValidNumber = (value: number, allowZero: boolean = false, allowNegative: boolean = false): boolean => { | |
| if(!typeof number !== "number") return false; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for string and number values in isValidNumber function