Support for string and numbers in isValidNumber function

README.md

@@ -79,7 +79,7 @@ console.log(isValidEmail('jhondoe@gmail.com')); // true
 
 ### `isValidNumber(value, allowZero, allowNegative)`
 
-- Validates if a value of type string is a valid number
+- Validates if a value of type string or number is a valid number
 - If allowZero equals true, '0' would return true
 - If allowNegative equals true, negative values would return true
 
@@ -92,11 +92,13 @@ console.log(isValidNumber('123a424', true, true)); // false
 console.log(isValidNumber('123a424', false, true)); // false
 console.log(isValidNumber('1.23a424', false, true)); // false
 console.log(isValidNumber('123-424', false, true)); // false
-console.log(isValidNumber('0')); // false  
+console.log(isValidNumber('0')); // false
 console.log(isValidNumber('0', true)); // true
 console.log(isValidNumber('-1', true, true)); // true
 console.log(isValidNumber('201')); // true
 console.log(isValidNumber('3.14159')); // true
+console.log(isValidNumber(452)); // true
+console.log(isValidNumber(3.1459)); // true
 ```
 
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cobuildlab/validation-utils",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "This is package to deal with common scenarios working with Javascript validations",
   "main": "lib/index.js",
   "types": "./lib/index.d.ts",

src/__tests__/test.ts

@@ -58,6 +58,8 @@ test('isValidNumber', () => {
   expect(isValidNumber('-1', true, true)).toBe(true);
   expect(isValidNumber('201')).toBe(true);
   expect(isValidNumber('3.14159')).toBe(true);
+  expect(isValidNumber(452)).toBe(true);
+  expect(isValidNumber(3.1459)).toBe(true);
 });
 
 test('isValidInteger', () => {

src/index.ts

@@ -57,19 +57,19 @@ export const isValidEmail = (email: string): boolean => {
 /**
  * Validate if a string is a valid number.
  *
- * @param {string} stringToTest - The string to validate as a number.
+ * @param {string|number} value - The string to validate as a number.
  * @param {boolean} [allowZero=false] - If the string should accept 0 as a valid number.
  * @param {boolean} [allowNegative=false] - If the string should negative values.
  * 
  * @returns {boolean} If the string is valid number or not.
  */
-export const isValidNumber = (stringToTest: string, allowZero: boolean = false, allowNegative: boolean = false): boolean => {
+export const isValidNumber = (value: string|number, allowZero: boolean = false, allowNegative: boolean = false): boolean => {
   const regExp = /^(-?[0-9]+)((\.|,)[0-9]+)?$/;
 
-  if (!regExp.test(stringToTest))
+  if (typeof value === 'string' && !regExp.test(value))
     return false;
 
-  const numberToTest = parseInt(stringToTest, 10);
+  const numberToTest = parseInt(value.toString(), 10);
 
   if (isNaN(numberToTest) || typeof numberToTest !== 'number') return false;