Skip to content

Drop unneeded admin session cleanup#2705

Open
jelly wants to merge 1 commit into
cockpit-project:mainfrom
jelly:aws-debuggerino
Open

Drop unneeded admin session cleanup#2705
jelly wants to merge 1 commit into
cockpit-project:mainfrom
jelly:aws-debuggerino

Conversation

@jelly

@jelly jelly commented Jul 9, 2026

Copy link
Copy Markdown
Member

It's not entirely clear if this breaks but running this reproducer on debian-trixie reproduces the same issue

systemctl reset-failed user@1002.service 2>/dev/null
systemctl stop user@1002.service 2>/dev/null

for i in 1 2 3 4 5 6; do
    echo "--- attempt $i ---"
    systemctl start user@1002.service
    loginctl terminate-user 1002 2>/dev/null || true
    loginctl kill-user 1002 2>/dev/null || true
    pkill -9 -u admin | grep -v "systemd --user" || true
    ps aux | grep admin
while pgrep -u admin; do sleep 0.2; done
    sleep 0.3
done

systemctl show user@1002.service -p Result -p ActiveState

@jelly jelly added the no-test label Jul 9, 2026
@jelly jelly force-pushed the aws-debuggerino branch 2 times, most recently from 7790c2b to a95438f Compare July 9, 2026 17:09
@jelly jelly removed the no-test label Jul 9, 2026
The nondestructive `_terminate_sessions` runs before our cleanups and
already calls `pkill -9 -u admin`.

This might cause fix the debian-trixie image issue where killing admin's
processes causes user@1002.service to fail often enough to run into the
`StartLimitBurst`.
@jelly jelly force-pushed the aws-debuggerino branch from a95438f to 4367bb4 Compare July 9, 2026 17:11
@jelly jelly changed the title Aws debuggerino Drop unneeded admin session cleanup Jul 10, 2026
@jelly jelly marked this pull request as ready for review July 10, 2026 06:56
@jelly jelly requested a review from allisonkarlitskaya July 10, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant