Skip to content

Drop unneeded admin session cleanup #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jelly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop unneeded admin session cleanup #2705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions test/machineslib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,13 +494,6 @@ def stop_all() -> None:
else:
m.execute("systemctl reset-failed libvirtd; systemctl try-restart libvirtd")

# user libvirtd instance tends to SIGABRT with "Failed to find user record for uid .." on shutdown
# during cleanup so make sure that there are no leftover user processes that bleed into the next test
self.addCleanup(m.execute, """
pkill -u admin || true;
while [ -n "$(pgrep -au admin | grep -v 'systemd --user')" ]; do sleep 0.5; done
""")

# FIXME: report downstream; AppArmor noisily denies some operations, but they are not required for us
self.allow_journal_messages(r'.* type=1400 .* apparmor="DENIED" operation="capable" profile="\S*libvirtd.* capname="sys_rawio".*') # noqa: E501
# AppArmor doesn't like the non-standard path for our storage pools
Expand Down