Skip to content

i18n: Fix translation strings #22034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Venefilyn
Copy link
Member

Some typos, some extra spacing, and wrong usage. These are all comments
from Weblate that I'm addressing.

Signed-off-by: Freya Gustavsson [email protected]

Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but we also depend on wrongly a typo in tests

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Venefilyn The typo needs to be fixed in the tests as well.

Thanks for fixing!

Some typos, some extra spacing, and wrong usage. These are all comments
from Weblate that I'm addressing.

Signed-off-by: Freya Gustavsson <[email protected]>
@Venefilyn Venefilyn force-pushed the int/fix-translation-strings branch from 82bf407 to d2d4a37 Compare May 27, 2025 11:38
@Venefilyn Venefilyn requested review from martinpitt and jelly May 27, 2025 11:38
@jelly
Copy link
Member

jelly commented May 27, 2025

Flake jackpot it seems.

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake jackpot> presumably due to the "3x affected" retries.

@Venefilyn Venefilyn merged commit d5ec39c into cockpit-project:main May 27, 2025
87 of 90 checks passed
@Venefilyn Venefilyn deleted the int/fix-translation-strings branch May 27, 2025 14:57
albert-byiringiro pushed a commit to albert-byiringiro/cockpit that referenced this pull request May 29, 2025
Some typos, some extra spacing, and wrong usage. These are all comments
from Weblate that I'm addressing.

Signed-off-by: Freya Gustavsson <[email protected]>
Venefilyn added a commit that referenced this pull request Jun 3, 2025
Some typos, some extra spacing, and wrong usage. These are all comments
from Weblate that I'm addressing.

Signed-off-by: Freya Gustavsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants